Skip to content

Commit cdd61e5

Browse files
committed
fix code style
1 parent d0ddb8e commit cdd61e5

2 files changed

Lines changed: 6 additions & 8 deletions

File tree

auth/src/main/java/org/apache/rocketmq/auth/authorization/chain/AclAuthorizationHandler.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ public AclAuthorizationHandler(AuthConfig config, Supplier<?> metadataService) {
5353

5454
@Override
5555
public CompletableFuture<Void> handle(DefaultAuthorizationContext context,
56-
HandlerChain<DefaultAuthorizationContext, CompletableFuture<Void>> chain) {
56+
HandlerChain<DefaultAuthorizationContext, CompletableFuture<Void>> chain) {
5757
if (this.authorizationMetadataProvider == null) {
5858
throw new AuthorizationException("The authorizationMetadataProvider is not configured");
5959
}
@@ -112,10 +112,10 @@ private List<PolicyEntry> matchPolicyEntries(DefaultAuthorizationContext context
112112
return null;
113113
}
114114
return entries.stream()
115-
.filter(entry -> entry.isMatchResource(context.getResource()))
116-
.filter(entry -> entry.isMatchAction(context.getActions()))
117-
.filter(entry -> entry.isMatchEnvironment(Environment.of(context.getSourceIp())))
118-
.collect(Collectors.toList());
115+
.filter(entry -> entry.isMatchResource(context.getResource()))
116+
.filter(entry -> entry.isMatchAction(context.getActions()))
117+
.filter(entry -> entry.isMatchEnvironment(Environment.of(context.getSourceIp())))
118+
.collect(Collectors.toList());
119119
}
120120

121121
private int comparePolicyEntries(PolicyEntry o1, PolicyEntry o2) {
@@ -159,6 +159,6 @@ private int comparePolicyEntries(PolicyEntry o1, PolicyEntry o2) {
159159

160160
private static void throwException(DefaultAuthorizationContext context, String detail) {
161161
throw new AuthorizationException("{} has no permission to access {} from {}, " + detail,
162-
context.getSubject().getSubjectKey(), context.getResource().getResourceKey(), context.getSourceIp());
162+
context.getSubject().getSubjectKey(), context.getResource().getResourceKey(), context.getSourceIp());
163163
}
164164
}

auth/src/test/java/org/apache/rocketmq/auth/authorization/AuthorizationEvaluatorTest.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@
2424
import org.apache.rocketmq.auth.authentication.manager.AuthenticationMetadataManager;
2525
import org.apache.rocketmq.auth.authentication.model.Subject;
2626
import org.apache.rocketmq.auth.authentication.model.User;
27-
import org.apache.rocketmq.auth.authorization.chain.AclAuthorizationHandler;
2827
import org.apache.rocketmq.auth.authorization.context.AuthorizationContext;
2928
import org.apache.rocketmq.auth.authorization.context.DefaultAuthorizationContext;
3029
import org.apache.rocketmq.auth.authorization.enums.Decision;
@@ -312,7 +311,6 @@ public void evaluate8() {
312311
Acl acl = AuthTestHelper.buildAcl("User:test", "Topic:test*", "Pub", "192.168.0.0/24", Decision.DENY);
313312
this.authorizationMetadataManager.createAcl(acl).join();
314313

315-
316314
Assert.assertThrows(AuthorizationException.class, () -> {
317315
Subject subject = Subject.of("User:test");
318316
Resource resource = Resource.ofTopic("test");

0 commit comments

Comments
 (0)