Skip to content

Commit d3d126e

Browse files
authored
[ISSUE #9476] Set queueId to 0 in DefaultTransactionalMessageCheckListener#toMessageExtBrokerInner to improve performance (#9477)
1 parent 9fc7851 commit d3d126e

1 file changed

Lines changed: 2 additions & 5 deletions

File tree

broker/src/main/java/org/apache/rocketmq/broker/transaction/queue/DefaultTransactionalMessageCheckListener.java

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -24,14 +24,12 @@
2424
import org.apache.rocketmq.common.message.MessageConst;
2525
import org.apache.rocketmq.common.message.MessageDecoder;
2626
import org.apache.rocketmq.common.message.MessageExt;
27+
import org.apache.rocketmq.common.message.MessageExtBrokerInner;
2728
import org.apache.rocketmq.logging.org.slf4j.Logger;
2829
import org.apache.rocketmq.logging.org.slf4j.LoggerFactory;
29-
import org.apache.rocketmq.common.message.MessageExtBrokerInner;
3030
import org.apache.rocketmq.store.PutMessageResult;
3131
import org.apache.rocketmq.store.PutMessageStatus;
3232

33-
import java.util.concurrent.ThreadLocalRandom;
34-
3533
public class DefaultTransactionalMessageCheckListener extends AbstractTransactionalMessageCheckListener {
3634
private static final Logger log = LoggerFactory.getLogger(LoggerName.TRANSACTION_LOGGER_NAME);
3735

@@ -62,15 +60,14 @@ public void resolveDiscardMsg(MessageExt msgExt) {
6260

6361
private MessageExtBrokerInner toMessageExtBrokerInner(MessageExt msgExt) {
6462
TopicConfig topicConfig = this.getBrokerController().getTopicConfigManager().createTopicOfTranCheckMaxTime(TCMT_QUEUE_NUMS, PermName.PERM_READ | PermName.PERM_WRITE);
65-
int queueId = ThreadLocalRandom.current().nextInt(99999999) % TCMT_QUEUE_NUMS;
6663
MessageExtBrokerInner inner = new MessageExtBrokerInner();
6764
inner.setTopic(topicConfig.getTopicName());
6865
inner.setBody(msgExt.getBody());
6966
inner.setFlag(msgExt.getFlag());
7067
MessageAccessor.setProperties(inner, msgExt.getProperties());
7168
inner.setPropertiesString(MessageDecoder.messageProperties2String(msgExt.getProperties()));
7269
inner.setTagsCode(MessageExtBrokerInner.tagsString2tagsCode(msgExt.getTags()));
73-
inner.setQueueId(queueId);
70+
inner.setQueueId(0);
7471
inner.setSysFlag(msgExt.getSysFlag());
7572
inner.setBornHost(msgExt.getBornHost());
7673
inner.setBornTimestamp(msgExt.getBornTimestamp());

0 commit comments

Comments
 (0)