Skip to content

Commit ea580f9

Browse files
committed
test(broker): skip flaky tests on macOS and Windows
- Update RocksdbGroupConfigTransferTest to skip on Windows platforms - Update RocksdbTransferOffsetAndCqTest to skip on macOS platforms Change-Id: Ieb8b562d067e8979c859e0c81895d8d0adb49900
1 parent fe99e99 commit ea580f9

2 files changed

Lines changed: 7 additions & 6 deletions

File tree

broker/src/test/java/org/apache/rocketmq/broker/offset/RocksdbTransferOffsetAndCqTest.java

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@
2929
import org.apache.rocketmq.broker.config.v1.RocksDBConsumerOffsetManager;
3030
import org.apache.rocketmq.common.BrokerConfig;
3131
import org.apache.rocketmq.common.CheckRocksdbCqWriteResult;
32+
import org.apache.rocketmq.common.MixAll;
3233
import org.apache.rocketmq.common.Pair;
3334
import org.apache.rocketmq.store.DefaultMessageStore;
3435
import org.apache.rocketmq.store.DispatchRequest;
@@ -167,12 +168,12 @@ public void testRocksdbCqWrite() throws RocksDBException {
167168
Assert.assertEquals(CheckRocksdbCqWriteResult.CheckStatus.CHECK_OK.getValue(), result.getCheckStatus());
168169
}
169170

170-
/**
171-
* No need to skip macOS platform.
172-
* @return true if some platform is NOT a good fit for this test case.
173-
*/
171+
// /**
172+
// * No need to skip macOS platform.
173+
// * @return true if some platform is NOT a good fit for this test case.
174+
// */
174175
private boolean notToBeExecuted() {
175-
return false;
176+
return MixAll.isMac();
176177
}
177178

178179
}

broker/src/test/java/org/apache/rocketmq/broker/subscription/RocksdbGroupConfigTransferTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -334,7 +334,7 @@ public void jsonUpgradeToRocksdb() {
334334
}
335335

336336
private boolean notToBeExecuted() {
337-
return MixAll.isMac();
337+
return MixAll.isMac() || MixAll.isWindows();
338338
}
339339

340340
}

0 commit comments

Comments
 (0)