From bac12272f93f538bf34c326826650d11c4467901 Mon Sep 17 00:00:00 2001 From: Divyansh Date: Sat, 22 Mar 2025 11:39:19 +0530 Subject: [PATCH] Refactored processResponseCommand to remove redundant operations --- .../remoting/netty/NettyRemotingAbstract.java | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/remoting/src/main/java/org/apache/rocketmq/remoting/netty/NettyRemotingAbstract.java b/remoting/src/main/java/org/apache/rocketmq/remoting/netty/NettyRemotingAbstract.java index a4f23f181a3..aa8c27c99af 100644 --- a/remoting/src/main/java/org/apache/rocketmq/remoting/netty/NettyRemotingAbstract.java +++ b/remoting/src/main/java/org/apache/rocketmq/remoting/netty/NettyRemotingAbstract.java @@ -383,19 +383,20 @@ private Runnable buildProcessRequestHandler(ChannelHandlerContext ctx, RemotingC public void processResponseCommand(ChannelHandlerContext ctx, RemotingCommand cmd) { final int opaque = cmd.getOpaque(); final ResponseFuture responseFuture = responseTable.get(opaque); - if (responseFuture != null) { - responseFuture.setResponseCommand(cmd); - + if (responseFuture != null) { responseTable.remove(opaque); - + if (responseFuture.getInvokeCallback() != null) { + responseFuture.setResponseCommand(cmd); executeInvokeCallback(responseFuture); } else { responseFuture.putResponse(cmd); responseFuture.release(); } } else { - log.warn("receive response, cmd={}, but not matched any request, address={}, channelId={}", cmd, RemotingHelper.parseChannelRemoteAddr(ctx.channel()), ctx.channel().id()); + log.warn("receive response, but not matched any request, " + + RemotingHelper.parseChannelRemoteAddr(ctx.channel())); + log.warn(cmd.toString()); } }