diff --git a/controller/src/main/java/org/apache/rocketmq/controller/BrokerHeartbeatManager.java b/controller/src/main/java/org/apache/rocketmq/controller/BrokerHeartbeatManager.java index dea393f3c5a..d73b5294046 100644 --- a/controller/src/main/java/org/apache/rocketmq/controller/BrokerHeartbeatManager.java +++ b/controller/src/main/java/org/apache/rocketmq/controller/BrokerHeartbeatManager.java @@ -26,9 +26,9 @@ import java.util.Map; public interface BrokerHeartbeatManager { - public static final long DEFAULT_BROKER_CHANNEL_EXPIRED_TIME = 1000 * 10; + long DEFAULT_BROKER_CHANNEL_EXPIRED_TIME = 1000 * 10; - public static BrokerHeartbeatManager newBrokerHeartbeatManager(ControllerConfig controllerConfig) { + static BrokerHeartbeatManager newBrokerHeartbeatManager(ControllerConfig controllerConfig) { if (controllerConfig.getControllerType().equals(ControllerConfig.JRAFT_CONTROLLER)) { return new RaftBrokerHeartBeatManager(controllerConfig); } else { @@ -37,9 +37,7 @@ public static BrokerHeartbeatManager newBrokerHeartbeatManager(ControllerConfig } /** - * initialize the resources - * - * @return + * Initialize the resources */ void initialize(); @@ -72,6 +70,8 @@ void onBrokerHeartbeat(final String clusterName, final String brokerName, final /** * Get broker live information by clusterName and brokerAddr + * + * @return broker live information or null if not found */ BrokerLiveInfo getBrokerLiveInfo(String clusterName, String brokerName, Long brokerId);