Skip to content

Commit e1bdbc9

Browse files
vdusekclaude
andauthored
fix: Resolve LogRecord attribute conflict in event manager logging (#802)
## Summary - Renamed `extra={'message': message}` to `extra={'raw_message': message}` in `ApifyEventManager._process_platform_messages` — the `message` key overwrites Python's built-in `LogRecord.message` attribute, corrupting the log record (especially visible on Python 3.13+). - Added `caplog.set_level(logging.INFO, logger='apify')` to `test_unknown_event_is_logged` — the unknown event is logged at `INFO` level but `caplog` only captures `WARNING`+ by default, causing the assertion to always fail. Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
1 parent c07461e commit e1bdbc9

2 files changed

Lines changed: 2 additions & 1 deletion

File tree

src/apify/events/_apify_event_manager.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@ async def _process_platform_messages(self, ws_url: str) -> None:
133133
await self._emit_persist_state_event_rec_task.stop()
134134
self.emit(event=Event.PERSIST_STATE, event_data=EventPersistStateData(is_migrating=True))
135135
except Exception:
136-
logger.exception('Cannot parse Actor event', extra={'message': message})
136+
logger.exception('Cannot parse Actor event', extra={'raw_message': message})
137137
except Exception:
138138
logger.exception('Error in websocket connection')
139139
if self._connected_to_platform_websocket is not None:

tests/unit/events/test_apify_event_manager.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -266,6 +266,7 @@ def listener(data: Any) -> None:
266266

267267
async def test_unknown_event_is_logged(monkeypatch: pytest.MonkeyPatch, caplog: pytest.LogCaptureFixture) -> None:
268268
"""Test that unknown events are logged and not emitted."""
269+
caplog.set_level(logging.INFO, logger='apify')
269270
async with (
270271
_platform_ws_server(monkeypatch) as (connected_ws_clients, client_connected),
271272
ApifyEventManager(Configuration.get_global_configuration()),

0 commit comments

Comments
 (0)