Add information about the default settings in the settings window; minor refactor changes

Author: arimger

Assets/Editor Toolbox/Editor/ToolboxManager.cs

@@ -1,5 +1,6 @@
 using System.Collections;
 using System.IO;
+
 using Unity.EditorCoroutines.Editor;
 using UnityEditor;
 using UnityEngine;
@@ -91,15 +92,15 @@ private static void ManageSceneViewCore(IToolboxSceneViewSettings settings)
 
         private static string GetSettingsFileGuid()
         {
-            var guids = AssetDatabase.FindAssets("t:" + settingsType);
+            var guids = AssetDatabase.FindAssets($"t:{settingsType}");
             string targetGuid = null;
             //try to find a settings file in a non-package directory
             for (var i = guids.Length - 1; i >= 0; i--)
             {
                 var guid = guids[i];
                 var path = AssetDatabase.GUIDToAssetPath(guid);
                 targetGuid = guid;
-                if (path.StartsWith("Assets"))
+                if (!IsDefaultSettingsPath(path))
                 {
                     break;
                 }
@@ -108,6 +109,11 @@ private static string GetSettingsFileGuid()
             return targetGuid;
         }
 
+        private static bool IsDefaultSettingsPath(string path)
+        {
+            return path.StartsWith("Packages");
+        }
+
         [InitializeOnLoadMethod]
         internal static void InitializeToolbox()
         {
@@ -223,7 +229,7 @@ void ReintializeProvider()
                         AssetDatabase.SaveAssets();
                         AssetDatabase.Refresh();
 
-                        ToolboxEditorLog.LogInfo("Created a settings file at - " + relativePath);
+                        ToolboxEditorLog.LogInfo($"Created a settings file at - {relativePath}");
 
                         ReintializeProvider();
                     }
@@ -232,7 +238,13 @@ void ReintializeProvider()
                 }
 
                 EditorGUILayout.Space();
-                EditorGUILayout.LabelField("Settings file location - " + SettingsPath);
+                EditorGUILayout.LabelField($"Settings file location - {SettingsPath}");
+                if (IsDefaultSettingsPath(SettingsPath))
+                {
+                    EditorGUILayout.HelpBox("The currently displayed settings file is the default one, located in the packages directory. " +
+                        "This means all changes can be easily lost. Create a new file for better maintainability.", MessageType.Info);
+                }
+
                 EditorGUILayout.Space();
 
                 globalSettingsEditor.OnInspectorGUI();

Assets/Editor Toolbox/Editor/ToolboxPrefs.cs

@@ -20,7 +20,6 @@ private static string GetKey(string causer, string propertyName)
             return string.Format("{0}{3}{1}{3}{2}", "Toolbox", causer, propertyName, ".");
         }
 
-
         public static void DeleteAll()
         {
             EditorPrefs.DeleteAll();