Implement basic support for generic types while using SerializeReference; more unit tests covering types filtering & constraints; add warning when pasting invalid/mismatched reference; update samples

Author: arimger

Assets/Editor Toolbox/Editor/ContextMenu/Operations/SerializeReference/PasteSerializeReferenceOperation.cs

@@ -5,9 +5,29 @@
 
 namespace Toolbox.Editor.ContextMenu.Operations
 {
-
     internal class PasteSerializeReferenceOperation : IContextMenuOperation
     {
+        private bool IsAssignmentValid(SerializedProperty property, object newValue)
+        {
+            if (newValue == null)
+            {
+                return true;
+            }
+
+            if (!TypeUtility.TryGetTypeFromManagedReferenceFullTypeName(property.managedReferenceFieldTypename, out var referenceType))
+            {
+                return true;
+            }
+
+            var newValueType = newValue.GetType();
+            if (TypeUtility.IsTypeAssignableFrom(referenceType, newValueType))
+            {
+                return true;
+            }
+
+            return false;
+        }
+
         private object GetCachedManagedReferenceValue()
         {
             var cachedData = CopySerializeReferenceOperation.Cache;
@@ -42,8 +62,15 @@ public void Perform(SerializedProperty property)
             var targetProperty = property.Copy();
             try
             {
+                var newValue = GetCachedManagedReferenceValue();
+                if (!IsAssignmentValid(targetProperty, newValue))
+                {
+                    ToolboxEditorLog.LogWarning("Cannot perform paste operation, types are mismatched.");
+                    return;
+                }
+
                 targetProperty.serializedObject.Update();
-                targetProperty.managedReferenceValue = GetCachedManagedReferenceValue();
+                targetProperty.managedReferenceValue = newValue;
                 targetProperty.serializedObject.ApplyModifiedProperties();
             }
             catch (Exception)

Assets/Editor Toolbox/Editor/Drawers/Regular/SerializedTypeDrawer.cs

@@ -5,7 +5,7 @@
 
 namespace Toolbox.Editor.Drawers
 {
-    using Toolbox.Editor.Internal;
+    using Toolbox.Editor.Internal.Types;
 
     [CustomPropertyDrawer(typeof(TypeConstraintAttribute), true)]
     [CustomPropertyDrawer(typeof(SerializedType))]
@@ -15,7 +15,6 @@ public sealed class SerializedTypeDrawer : PropertyDrawerBase
         private static readonly TypeAppearanceContext sharedAppearance = new TypeAppearanceContext(sharedConstraint, TypeGrouping.None, true);
         private static readonly TypeField typeField = new TypeField(sharedConstraint, sharedAppearance);
 
-
         private bool IsDefaultField(TypeConstraintAttribute attribute)
         {
             return attribute == null || attribute.AssemblyType == null;
@@ -65,7 +64,6 @@ private void UpdateAppearance(TypeConstraintAttribute attribute)
             sharedAppearance.TypeGrouping = attribute.TypeGrouping;
         }
 
-
         protected override float GetPropertyHeightSafe(SerializedProperty property, GUIContent label)
         {
             return EditorStyles.popup.CalcHeight(GUIContent.none, 0);
@@ -101,7 +99,6 @@ protected override void OnGUISafe(Rect position, SerializedProperty property, GU
             EditorGUI.EndProperty();
         }
 
-
         ///<inheritdoc/>
         public override bool IsPropertyValid(SerializedProperty property)
         {

Assets/Editor Toolbox/Editor/Drawers/Toolbox/PropertySelf/ReferencePickerAttributeDrawer.cs

@@ -7,6 +7,7 @@
 namespace Toolbox.Editor.Drawers
 {
     using Toolbox.Editor.Internal;
+    using Toolbox.Editor.Internal.Types;
 
     public class ReferencePickerAttributeDrawer : ToolboxSelfPropertyDrawer<ReferencePickerAttribute>
     {
@@ -42,7 +43,7 @@ private Type GetParentType(ReferencePickerAttribute attribute, SerializedPropert
 
         private void CreateTypeProperty(SerializedProperty property, Type parentType, ReferencePickerAttribute attribute, Rect position)
         {
-            TypeUtilities.TryGetTypeFromManagedReferenceFullTypeName(property.managedReferenceFullTypename, out var currentType);
+            TypeUtility.TryGetTypeFromManagedReferenceFullTypeName(property.managedReferenceFullTypename, out var currentType);
             typeField.OnGui(position, attribute.AddTextSearchField, (type) =>
             {
                 try

Assets/Editor Toolbox/Editor/Internal/TypeAppearanceContext.cs.meta

@@ -2,7 +2,7 @@
 
 using UnityEngine;
 
-namespace Toolbox.Editor.Internal
+namespace Toolbox.Editor.Internal.Types
 {
     public class TypeAppearanceContext
     {