Possibility to define custom validation method in the EditorButton attribute

Author: arimger

Assets/Editor Toolbox/Editor/Drawers/Toolbox/Decorator/EditorButtonAttributeDrawer.cs

@@ -9,6 +9,30 @@ namespace Toolbox.Editor.Drawers
 {
     public class EditorButtonAttributeDrawer : ToolboxDecoratorDrawer<EditorButtonAttribute>
     {
+        private bool IsCoroutine(MethodInfo method)
+        {
+            return method.ReturnType == typeof(IEnumerator);
+        }
+
+        private MethodInfo GetMethod(EditorButtonAttribute attribute, Object[] targetObjects, string methodName)
+        {
+            var methodInfo = ReflectionUtility.GetObjectMethod(methodName, targetObjects);
+            if (methodInfo == null)
+            {
+                ToolboxEditorLog.AttributeUsageWarning(attribute, string.Format("{0} method not found.", methodName));
+                return null;
+            }
+
+            var parameters = methodInfo.GetParameters();
+            if (parameters.Length > 0)
+            {
+                ToolboxEditorLog.AttributeUsageWarning(attribute, string.Format("{0} method has to be parameterless.", methodName));
+                return null;
+            }
+
+            return methodInfo;
+        }
+
         private bool IsClickable(ButtonActivityType activityType)
         {
             switch (activityType)
@@ -26,9 +50,48 @@ private bool IsClickable(ButtonActivityType activityType)
             return true;
         }
 
-        private bool IsCoroutine(MethodInfo method)
+        private bool IsClickable(EditorButtonAttribute attribute, Object[] targetObjects)
         {
-            return method.ReturnType == typeof(IEnumerator);
+            if (!IsClickable(attribute.ActivityType))
+            {
+                return false;
+            }
+
+            var validateMethodName = attribute.ValidateMethodName;
+            if (string.IsNullOrEmpty(validateMethodName))
+            {
+                return true;
+            }
+
+            var validateMethodInfo = GetMethod(attribute, targetObjects, validateMethodName);
+            if (validateMethodInfo == null)
+            {
+                return true;
+            }
+
+            var returnType = validateMethodInfo.ReturnType;
+            if (returnType != typeof(bool))
+            {
+                ToolboxEditorLog.AttributeUsageWarning(attribute, "Validation method is invalid, return type has to be 'bool'.");
+                return true;
+            }
+
+            for (var i = 0; i < targetObjects.Length; i++)
+            {
+                var target = targetObjects[i];
+                if (target == null)
+                {
+                    continue;
+                }
+
+                var result = (bool)validateMethodInfo.Invoke(target, null);
+                if (!result)
+                {
+                    return false;
+                }
+            }
+
+            return true;
         }
 
         private void CallMethods(EditorButtonAttribute attribute, Object[] targetObjects)
@@ -78,7 +141,7 @@ protected override void OnGuiCloseSafe(EditorButtonAttribute attribute)
                 return;
             }
 
-            var disable = !IsClickable(attribute.ActivityType);
+            var disable = !IsClickable(attribute, targetObjects);
             using (new EditorGUI.DisabledScope(disable))
             {
                 var label = string.IsNullOrEmpty(attribute.ExtraLabel)

Assets/Editor Toolbox/Runtime/Attributes/Toolbox/DecoratorAttributes/EditorButtonAttribute.cs

@@ -20,11 +20,12 @@ public EditorButtonAttribute(string methodName, string extraLabel = null, Button
         }
 
         public string MethodName { get; private set; }
-
+        /// <summary>
+        /// If not <see langword="null"/> will be used to retrive validation method.
+        /// </summary>
+        public string ValidateMethodName { get; set; }
         public string ExtraLabel { get; private set; }
-
         public string Tooltip { get; set; }
-
         public ButtonActivityType ActivityType { get; private set; }
     }
 

Assets/Examples/Scripts/SampleBehaviour4.cs

@@ -16,7 +16,7 @@ public class SampleBehaviour4 : MonoBehaviour
 
     [Label("Button", skinStyle: SkinStyle.Box)]
 
-    [EditorButton(nameof(TestMethod), Tooltip = "Custom Tooltip")]
+    [EditorButton(nameof(TestMethod), Tooltip = "Custom Tooltip", ValidateMethodName = nameof(ValidationMethod))]
     [EditorButton(nameof(TestCoroutine), "<b>Test Coroutine</b>", activityType: ButtonActivityType.OnPlayMode)]
     [EditorButton(nameof(TestStaticMethod), activityType: ButtonActivityType.OnEditMode)]
     public int var1;
@@ -26,6 +26,11 @@ private void TestMethod()
         Debug.Log(nameof(TestMethod) + " is called");
     }
 
+    private bool ValidationMethod()
+    {
+        return var1 == 0;
+    }
+
     private IEnumerator TestCoroutine()
     {
         Debug.Log("Coroutine started");