Fix Copy/Paste context menu operations for serialized references

Author: arimger

Assets/Editor Toolbox/Editor/ContextMenu/Operations/SerializeReference/CopySerializeReferenceCache.cs

@@ -9,17 +9,18 @@ namespace Toolbox.Editor.ContextMenu.Operations
     /// </summary>
     internal class CopySerializeReferenceCache
     {
-        public CopySerializeReferenceCache(Type referenceType, IReadOnlyList<CopySerializeReferenceEntry> entires)
+        public CopySerializeReferenceCache(Type referenceType, IReadOnlyList<CopySerializeReferenceEntry> entires, bool isArrayCopy)
         {
             ReferenceType = referenceType;
             Entries = entires;
+            IsArrayCopy = isArrayCopy;
         }
 
         /// <summary>
         /// Base managed reference type of the source <see cref="UnityEditor.SerializedProperty"/>.
         /// </summary>
         public Type ReferenceType { get; }
         public IReadOnlyList<CopySerializeReferenceEntry> Entries { get; }
-        public bool IsArrayCopy => Entries != null && Entries.Count > 1;
+        public bool IsArrayCopy { get; }
     }
 }

Assets/Editor Toolbox/Editor/ContextMenu/Operations/SerializeReference/CopySerializeReferenceOperation.cs

@@ -51,6 +51,7 @@ public bool IsEnabled(SerializedProperty property)
 
         public void Perform(SerializedProperty property)
         {
+            var isArrayCopy = false;
             var entries = new List<CopySerializeReferenceEntry>();
             if (property.propertyType == SerializedPropertyType.ManagedReference)
             {
@@ -59,6 +60,7 @@ public void Perform(SerializedProperty property)
             }
             else if (property.isArray)
             {
+                isArrayCopy = true;
                 var propertiesCount = property.arraySize;
                 for (var i = 0; i < propertiesCount; i++)
                 {
@@ -69,7 +71,7 @@ public void Perform(SerializedProperty property)
             }
 
             PropertyUtility.TryGetSerializeReferenceType(property, out var referenceType);
-            Cache = new CopySerializeReferenceCache(referenceType, entries);
+            Cache = new CopySerializeReferenceCache(referenceType, entries, isArrayCopy);
         }
 
         public GUIContent Label => new GUIContent("Copy Serialized References");

Assets/Editor Toolbox/Editor/ContextMenu/Operations/SerializeReference/PasteSerializeReferenceOperation.cs

@@ -36,7 +36,7 @@ private bool IsAssignmentValid(Type targetType, CopySerializeReferenceEntry entr
                 return true;
             }
 
-            return TypeUtility.IsTypeAssignableFrom(targetType, entry.ReferenceType);
+            return TypeUtility.IsTypeAssignableFrom(targetType, entryType);
         }
 
         private bool IsOperationSupported(SerializedProperty targetProperty, CopySerializeReferenceCache cache)

Assets/Editor Toolbox/Editor/Utilities/PropertyUtility.cs

@@ -672,20 +672,21 @@ internal static bool IsSerializeReferenceProperty(SerializedProperty property)
 
         internal static bool TryGetSerializeReferenceType(SerializedProperty property, out Type referenceType)
         {
-            var fieldInfo = GetFieldInfo(property, out var propertyType);
+            var fieldInfo = GetFieldInfo(property, propertyType: out _);
             if (fieldInfo == null)
             {
                 referenceType = null;
                 return false;
             }
 
-            if (property.isArray)
+            var fieldType = fieldInfo.FieldType;
+            if (property.isArray || IsSerializableArrayElement(property))
             {
-                referenceType = GetElementTypeFromArrayType(propertyType);
+                referenceType = GetElementTypeFromArrayType(fieldType);
             }
             else
             {
-                referenceType = fieldInfo.FieldType;
+                referenceType = fieldType;
             }
 
             return true;