Skip to content

Commit 5834304

Browse files
authored
Merge pull request #168 from authzed/remove-lockfiles
Remove lockfiles
2 parents afbf487 + 17f67da commit 5834304

8 files changed

Lines changed: 27 additions & 2661 deletions

File tree

.github/workflows/automatic-api-update.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ jobs:
4040
uses: bahmutov/npm-install@v1
4141
if: steps.buf-update.outputs.updated == 'true'
4242
with:
43+
useLockFile: false
4344
working-directory: ./
4445
- name: "Install buf"
4546
uses: "bufbuild/buf-setup-action@v1.39.0"

.github/workflows/manual-api-update.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@ jobs:
4444
uses: bahmutov/npm-install@v1
4545
if: steps.buf-update.outputs.updated == 'true'
4646
with:
47+
useLockFile: false
4748
working-directory: ./
4849
- name: "Install buf"
4950
uses: "bufbuild/buf-setup-action@v1.39.0"

.github/workflows/publish.yaml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,12 @@ jobs:
1414
- uses: actions/checkout@v4
1515
- uses: actions/setup-node@v4
1616
with:
17+
cache-dependency-path: ./package.json
18+
cache: "yarn"
1719
node-version: 18
1820
- uses: bahmutov/npm-install@v1
21+
with:
22+
useLockFile: false
1923
# Set the version in package.json to match the tag
2024
- name: Write release version
2125
run: |
@@ -39,13 +43,17 @@ jobs:
3943
- uses: actions/setup-node@v4
4044
with:
4145
node-version: 18
46+
cache-dependency-path: ./package.json
4247
cache: "yarn"
4348
# Install deps in base package and build into js-dist
4449
- uses: bahmutov/npm-install@v1
50+
with:
51+
useLockFile: false
4552
- name: Run build
4653
run: yarn build-js-client
4754
- uses: bahmutov/npm-install@v1
4855
with:
56+
useLockFile: false
4957
working-directory: ./js-dist
5058
# Set the version in package.json to match the tag
5159
- name: Write release version

.github/workflows/test.yaml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,11 @@ jobs:
4040
- uses: actions/setup-node@v4
4141
with:
4242
node-version: ${{ matrix.node-version }}
43+
cache-dependency-path: ./package.json
4344
cache: "yarn"
4445
- uses: bahmutov/npm-install@v1
46+
with:
47+
useLockFile: false
4548
- name: Run lint
4649
run: CI=true yarn lint
4750
- name: Run Yarn tests
@@ -63,13 +66,17 @@ jobs:
6366
- uses: actions/setup-node@v4
6467
with:
6568
node-version: ${{ matrix.node-version }}
69+
cache-dependency-path: ./package.json
6670
cache: "yarn"
6771
- uses: bahmutov/npm-install@v1
72+
with:
73+
useLockFile: false
6874
- name: Run build
6975
run: yarn build-js-client
7076
working-directory: ./
7177
- uses: bahmutov/npm-install@v1
7278
with:
79+
useLockFile: false
7380
working-directory: ./js-dist
7481
- name: Run tests
7582
run: CI=true yarn only-run-tests

.gitignore

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,3 +4,12 @@ src/authzedapi/authzed/api/v0
44
src/authzedapi/authzed/api/v1alpha1
55
js-dist/src/authzedapi/authzed/api/v0
66
js-dist/src/authzedapi/authzed/api/v1alpha1
7+
8+
# Because of how node's dependency management works,
9+
# and the fact that a lockfile in a published package
10+
# isn't exported, keeping these files out of the repo
11+
# will make our tests reflect installed usage more closely.
12+
yarn.lock
13+
package-lock.json
14+
js-dist/yarn.lock
15+
js-dist/package-lock.json

.npmrc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
package-lock=false

0 commit comments

Comments
 (0)