Skip to content

Commit 1a019a8

Browse files
authored
Revert "Sync upstream (#126)"
This reverts commit 31c0e14.
1 parent 076bd9c commit 1a019a8

13 files changed

Lines changed: 196 additions & 296 deletions

composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
"authors": [
1313
{
1414
"name": "Ghazi Triki",
15-
"email": "ghazi.triki@riadvice.tn",
15+
"email": "ghazi.nocturne@gmail.com",
1616
"role": "Developer"
1717
},
1818
{

src/BigBlueButton.php

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -587,9 +587,4 @@ private function requestUrl(string $url, string $payload = '', string $contentTy
587587

588588
return $response->getBody();
589589
}
590-
591-
public function buildUrl(string $method = '', string $params = '', bool $append = true): string
592-
{
593-
return $this->urlBuilder->buildUrl($method, $params, $append);
594-
}
595590
}

src/Core/GuestPolicy.php

Lines changed: 0 additions & 30 deletions
This file was deleted.

src/Core/MeetingLayout.php

Lines changed: 0 additions & 30 deletions
This file was deleted.

src/Parameters/CreateMeetingParameters.php

Lines changed: 15 additions & 56 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,6 @@
1818
*/
1919
namespace BigBlueButton\Parameters;
2020

21-
use BigBlueButton\Core\GuestPolicy;
22-
use BigBlueButton\Core\MeetingLayout;
23-
2421
/**
2522
* @method string getName()
2623
* @method $this setName(string $name)
@@ -36,8 +33,6 @@
3633
* @method $this setDialNumber(string $dialNumber)
3734
* @method string getVoiceBridge()
3835
* @method $this setVoiceBridge(string $voiceBridge)
39-
* @method string getWebVoice()
40-
* @method $this setWebVoice(string $webVoice)
4136
* @method int getMaxParticipants()
4237
* @method $this setMaxParticipants(int $maxParticipants)
4338
* @method string getLogoutURL()
@@ -106,8 +101,6 @@
106101
* @method $this setEndWhenNoModeratorDelayInMinutes(int $endWhenNoModeratorDelayInMinutes)
107102
* @method string getMeetingLayout()
108103
* @method $this setMeetingLayout(string $meetingLayout)
109-
* @method string getMeetingEndedURL()
110-
* @method $this setMeetingEndedURL(string $meetingEndedURL)
111104
* @method bool|null isLearningDashboardEnabled()
112105
* @method $this setLearningDashboardEnabled(bool $isLearningDashboardEnabled)
113106
* @method int getLearningDashboardCleanupDelayInMinutes()
@@ -124,39 +117,15 @@
124117
*/
125118
class CreateMeetingParameters extends MetaParameters
126119
{
127-
/**
128-
* @deprecated Use GuestPolicy::ALWAYS_ACCEPT instead.
129-
*/
130-
public const ALWAYS_ACCEPT = GuestPolicy::ALWAYS_ACCEPT;
131-
/**
132-
* @deprecated Use GuestPolicy::ALWAYS_DENY instead.
133-
*/
134-
public const ALWAYS_DENY = GuestPolicy::ALWAYS_DENY;
135-
/**
136-
* @deprecated Use GuestPolicy::ASK_MODERATOR instead.
137-
*/
138-
public const ASK_MODERATOR = GuestPolicy::ASK_MODERATOR;
139-
/**
140-
* @deprecated Use GuestPolicy::ALWAYS_ACCEPT_AUTH instead.
141-
*/
142-
public const ALWAYS_ACCEPT_AUTH = GuestPolicy::ALWAYS_ACCEPT_AUTH;
120+
public const ALWAYS_ACCEPT = 'ALWAYS_ACCEPT';
121+
public const ALWAYS_DENY = 'ALWAYS_DENY';
122+
public const ASK_MODERATOR = 'ASK_MODERATOR';
123+
public const ALWAYS_ACCEPT_AUTH = 'ALWAYS_ACCEPT_AUTH';
143124

144-
/**
145-
* @deprecated Use MeetingLayout::CUSTOM_LAYOUT instead.
146-
*/
147-
public const CUSTOM_LAYOUT = MeetingLayout::CUSTOM_LAYOUT;
148-
/**
149-
* @deprecated Use MeetingLayout::SMART_LAYOUT instead.
150-
*/
151-
public const SMART_LAYOUT = MeetingLayout::SMART_LAYOUT;
152-
/**
153-
* @deprecated Use MeetingLayout::PRESENTATION_FOCUS instead.
154-
*/
155-
public const PRESENTATION_FOCUS = MeetingLayout::PRESENTATION_FOCUS;
156-
/**
157-
* @deprecated Use MeetingLayout::VIDEO_FOCUS instead.
158-
*/
159-
public const VIDEO_FOCUS = MeetingLayout::VIDEO_FOCUS;
125+
const CUSTOM_LAYOUT = 'CUSTOM_LAYOUT';
126+
const SMART_LAYOUT = 'SMART_LAYOUT';
127+
const PRESENTATION_FOCUS = 'PRESENTATION_FOCUS';
128+
const VIDEO_FOCUS = 'VIDEO_FOCUS';
160129

161130
/**
162131
* @var string
@@ -193,11 +162,6 @@ class CreateMeetingParameters extends MetaParameters
193162
*/
194163
protected $voiceBridge;
195164

196-
/**
197-
* @var string
198-
*/
199-
protected $webVoice;
200-
201165
/**
202166
* @var int
203167
*/
@@ -351,7 +315,7 @@ class CreateMeetingParameters extends MetaParameters
351315
/**
352316
* @var string
353317
*/
354-
protected $guestPolicy = GuestPolicy::ALWAYS_ACCEPT;
318+
protected $guestPolicy = self::ALWAYS_ACCEPT;
355319

356320
/**
357321
* @var bool
@@ -373,11 +337,6 @@ class CreateMeetingParameters extends MetaParameters
373337
*/
374338
protected $meetingLayout;
375339

376-
/**
377-
* @var string
378-
*/
379-
protected $meetingEndedURL;
380-
381340
/**
382341
* @var bool
383342
*/
@@ -630,15 +589,15 @@ public function setParentMeetingId(string $parentMeetingID)
630589
*/
631590
public function isGuestPolicyAlwaysDeny()
632591
{
633-
return $this->guestPolicy === GuestPolicy::ALWAYS_DENY;
592+
return $this->guestPolicy === self::ALWAYS_DENY;
634593
}
635594

636595
/**
637596
* @return CreateMeetingParameters
638597
*/
639598
public function setGuestPolicyAlwaysDeny()
640599
{
641-
$this->guestPolicy = GuestPolicy::ALWAYS_DENY;
600+
$this->guestPolicy = self::ALWAYS_DENY;
642601

643602
return $this;
644603
}
@@ -648,7 +607,7 @@ public function setGuestPolicyAlwaysDeny()
648607
*/
649608
public function isGuestPolicyAskModerator()
650609
{
651-
return $this->guestPolicy === GuestPolicy::ASK_MODERATOR;
610+
return $this->guestPolicy === self::ASK_MODERATOR;
652611
}
653612

654613
/**
@@ -657,7 +616,7 @@ public function isGuestPolicyAskModerator()
657616
*/
658617
public function setGuestPolicyAskModerator()
659618
{
660-
$this->guestPolicy = GuestPolicy::ASK_MODERATOR;
619+
$this->guestPolicy = self::ASK_MODERATOR;
661620

662621
return $this;
663622
}
@@ -667,7 +626,7 @@ public function setGuestPolicyAskModerator()
667626
*/
668627
public function isGuestPolicyAlwaysAcceptAuth()
669628
{
670-
return $this->guestPolicy === GuestPolicy::ALWAYS_ACCEPT_AUTH;
629+
return $this->guestPolicy === self::ALWAYS_ACCEPT_AUTH;
671630
}
672631

673632
/**
@@ -676,7 +635,7 @@ public function isGuestPolicyAlwaysAcceptAuth()
676635
*/
677636
public function setGuestPolicyAlwaysAcceptAuth()
678637
{
679-
$this->guestPolicy = GuestPolicy::ALWAYS_ACCEPT_AUTH;
638+
$this->guestPolicy = self::ALWAYS_ACCEPT_AUTH;
680639

681640
return $this;
682641
}

src/Responses/GetRecordingTextTracksResponse.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
/**
33
* BigBlueButton open source conferencing system - https://www.bigbluebutton.org/.
44
*
5-
* Copyright (c) 2016-2021 BigBlueButton Inc. and by respective authors (see below).
5+
* Copyright (c) 2016-2018 BigBlueButton Inc. and by respective authors (see below).
66
*
77
* This program is free software; you can redistribute it and/or modify it under the
88
* terms of the GNU Lesser General Public License as published by the Free Software

tests/TestCase.php

Lines changed: 9 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,6 @@
1818
*/
1919
namespace BigBlueButton;
2020

21-
use BigBlueButton\Core\GuestPolicy;
22-
use BigBlueButton\Core\MeetingLayout;
2321
use BigBlueButton\Parameters\CreateMeetingParameters as CreateMeetingParameters;
2422
use BigBlueButton\Parameters\EndMeetingParameters;
2523
use BigBlueButton\Parameters\JoinMeetingParameters as JoinMeetingParameters;
@@ -75,7 +73,6 @@ protected function generateCreateParams()
7573
'autoStartRecording' => $this->faker->boolean(50),
7674
'dialNumber' => $this->faker->phoneNumber,
7775
'voiceBridge' => $this->faker->randomNumber(5),
78-
'webVoice' => $this->faker->word,
7976
'logoutURL' => $this->faker->url,
8077
'maxParticipants' => $this->faker->numberBetween(2, 100),
8178
'record' => $this->faker->boolean(50),
@@ -86,7 +83,7 @@ protected function generateCreateParams()
8683
'webcamsOnlyForModerator' => $this->faker->boolean(50),
8784
'logo' => $this->faker->imageUrl(330, 70),
8885
'copyright' => $this->faker->text,
89-
'guestPolicy' => $this->faker->randomElement([GuestPolicy::ALWAYS_ACCEPT, GuestPolicy::ALWAYS_DENY, GuestPolicy::ASK_MODERATOR]),
86+
'guestPolicy' => CreateMeetingParameters::ALWAYS_ACCEPT,
9087
'muteOnStart' => $this->faker->boolean(50),
9188
'lockSettingsDisableCam' => $this->faker->boolean(50),
9289
'lockSettingsDisableMic' => $this->faker->boolean(50),
@@ -98,7 +95,6 @@ protected function generateCreateParams()
9895
'lockSettingsLockOnJoin' => $this->faker->boolean(50),
9996
'lockSettingsLockOnJoinConfigurable' => $this->faker->boolean(50),
10097
'allowModsToUnmuteUsers' => $this->faker->boolean(50),
101-
'allowModsToEjectCameras' => $this->faker->boolean(50),
10298
'meta_presenter' => $this->faker->name,
10399
'meta_endCallbackUrl' => $this->faker->url,
104100
'meta_bbb-recording-ready-url' => $this->faker->url,
@@ -108,16 +104,16 @@ protected function generateCreateParams()
108104
'endWhenNoModerator' => $this->faker->boolean(50),
109105
'endWhenNoModeratorDelayInMinutes' => $this->faker->numberBetween(1, 100),
110106
'meetingLayout' => $this->faker->randomElement([
111-
MeetingLayout::CUSTOM_LAYOUT,
112-
MeetingLayout::SMART_LAYOUT,
113-
MeetingLayout::PRESENTATION_FOCUS,
114-
MeetingLayout::VIDEO_FOCUS
107+
CreateMeetingParameters::CUSTOM_LAYOUT,
108+
CreateMeetingParameters::SMART_LAYOUT,
109+
CreateMeetingParameters::PRESENTATION_FOCUS,
110+
CreateMeetingParameters::VIDEO_FOCUS
115111
]),
116112
'learningDashboardEnabled' => $this->faker->boolean(50),
117113
'learningDashboardCleanupDelayInMinutes' => $this->faker->numberBetween(1, 100),
114+
'allowModsToEjectCameras' => $this->faker->boolean(50),
118115
'breakoutRoomsEnabled' => $this->faker->boolean(50),
119116
'breakoutRoomsPrivateChatEnabled' => $this->faker->boolean(50),
120-
'meetingEndedURL' => $this->faker->url,
121117
'breakoutRoomsRecord' => $this->faker->boolean(50),
122118
'allowRequestsWithoutSession' => $this->faker->boolean(50),
123119
'virtualBackgroundsDisabled' => $this->faker->boolean(50),
@@ -152,12 +148,11 @@ protected function getCreateMock($params)
152148
->setModeratorPassword($params['moderatorPW'])
153149
->setDialNumber($params['dialNumber'])
154150
->setVoiceBridge($params['voiceBridge'])
155-
->setWebVoice($params['webVoice'])
156-
->setLogoutURL($params['logoutURL'])
151+
->setLogoutUrl($params['logoutURL'])
157152
->setMaxParticipants($params['maxParticipants'])
158153
->setRecord($params['record'])
159154
->setDuration($params['duration'])
160-
->setWelcome($params['welcome'])
155+
->setWelcomeMessage($params['welcome'])
161156
->setAutoStartRecording($params['autoStartRecording'])
162157
->setAllowStartStopRecording($params['allowStartStopRecording'])
163158
->setModeratorOnlyMessage($params['moderatorOnlyMessage'])
@@ -177,17 +172,14 @@ protected function getCreateMock($params)
177172
->setLockSettingsLockOnJoin($params['lockSettingsLockOnJoin'])
178173
->setLockSettingsLockOnJoinConfigurable($params['lockSettingsLockOnJoinConfigurable'])
179174
->setAllowModsToUnmuteUsers($params['allowModsToUnmuteUsers'])
180-
->setGuestPolicy($params['guestPolicy'])
175+
->setGuestPolicyAlwaysAccept()
181176
->addMeta('presenter', $params['meta_presenter'])
182177
->setBannerText($params['bannerText'])
183178
->setBannerColor($params['bannerColor'])
184179
->setMeetingKeepEvents($params['meetingKeepEvents'])
185180
->setEndWhenNoModerator($params['endWhenNoModerator'])
186181
->setEndWhenNoModeratorDelayInMinutes($params['endWhenNoModeratorDelayInMinutes'])
187-
->setAllowModsToEjectCameras($params['allowModsToEjectCameras'])
188-
->setMeetingEndedURL($params['meetingEndedURL'])
189182
->setMeetingLayout($params['meetingLayout'])
190-
->setMeetingKeepEvents($params['meetingKeepEvents'])
191183
->setLearningDashboardEnabled($params['learningDashboardEnabled'])
192184
->setLearningDashboardCleanupDelayInMinutes($params['learningDashboardCleanupDelayInMinutes'])
193185
->setAllowModsToEjectCameras($params['allowModsToEjectCameras'])

0 commit comments

Comments
 (0)