Implement negotiated changes

Author: DigitalTimK

.gitignore

@@ -1,6 +1,5 @@
 composer.phar
 /vendor/
-/var/
 composer.lock
 .DS_Store
 

composer.json

@@ -40,7 +40,8 @@
     "bmitch/churn-php": "^1.7.1",
     "phpmetrics/phpmetrics": "^v2.8.2",
     "wapmorgan/php-deprecation-detector": "^2.0.33",
-    "phpstan/phpstan": "^1.10"
+    "phpstan/phpstan": "^1.10",
+    "tracy/tracy": "^2.10"
   },
   "scripts": {
     "code-check": "./vendor/bin/phpstan analyse",

src/Responses/GetRecordingsResponse.php

@@ -27,7 +27,6 @@
  */
 class GetRecordingsResponse extends BaseResponse
 {
-
     /**
      * @return Record[]
      */

src/Responses/HooksListResponse.php

@@ -27,7 +27,6 @@
  */
 class HooksListResponse extends BaseResponse
 {
-
     /**
      * @return Hook[]
      */

src/Util/FileDumper.php

@@ -31,14 +31,15 @@ class DeleteRecordingsParametersTest extends TestCase
 {
     public function testDeleteRecordingParameter(): void
     {
-        $recordingId     = $this->faker->uuid;
-        $deleteRecording = new DeleteRecordingsParameters($recordingId);
+        $recordingId1 = $this->faker->uuid;
+        $recordingId2 = $this->faker->uuid;
 
-        $this->assertEquals($recordingId, $deleteRecording->getRecordingId());
+        // Test by constructor
+        $deleteRecording = new DeleteRecordingsParameters($recordingId1);
+        $this->assertEquals($recordingId1, $deleteRecording->getRecordingId());
 
         // Test setters that are ignored by the constructor
-        $recordingIdNew = $this->faker->uuid;
-        $deleteRecording->setRecordingId($recordingIdNew);
-        $this->assertEquals($recordingIdNew, $deleteRecording->getRecordingId());
+        $deleteRecording->setRecordingId($recordingId2);
+        $this->assertEquals($recordingId2, $deleteRecording->getRecordingId());
     }
 }

tests/Parameters/DeleteRecordingsParametersTest.php

@@ -31,20 +31,20 @@ class PublishRecordingsParametersTest extends TestCase
 {
     public function testPublishRecordingsParameters(): void
     {
-        $recordingId    = $this->faker->uuid;
-        $publish        = $this->faker->boolean(50);
-        $newRecordingId = $this->faker->uuid;
-        $newPublish     = !$publish;
+        $recordingId1 = $this->faker->uuid;
+        $publish1     = $this->faker->boolean(50);
+        $recordingId2 = $this->faker->uuid;
+        $publish2     = !$publish1;
 
-        $publishRecording = new PublishRecordingsParameters($recordingId, $publish);
-
-        $this->assertEquals($recordingId, $publishRecording->getRecordingId());
-        $this->assertEquals($publish, $publishRecording->isPublish());
+        // Test by constructor
+        $publishRecording = new PublishRecordingsParameters($recordingId1, $publish1);
+        $this->assertEquals($recordingId1, $publishRecording->getRecordingId());
+        $this->assertEquals($publish1, $publishRecording->isPublish());
 
         // Test setters that are ignored by the constructor
-        $publishRecording->setRecordingId($newRecordingId);
-        $publishRecording->setPublish($newPublish);
-        $this->assertEquals($newRecordingId, $publishRecording->getRecordingId());
-        $this->assertEquals($newPublish, $publishRecording->isPublish());
+        $publishRecording->setRecordingId($recordingId2);
+        $publishRecording->setPublish($publish2);
+        $this->assertEquals($recordingId2, $publishRecording->getRecordingId());
+        $this->assertEquals($publish2, $publishRecording->isPublish());
     }
 }