Improve code to phpstan level 4

Author: DigitalTimK

README.md

@@ -31,7 +31,7 @@ install and usage example.
 Bugs and feature request are tracked on [GitHub](https://github.com/bigbluebutton/bigbluebutton-api-php/issues)
 
 ## Contributing guidelines
-### Code Quality (style)
+### Code Quality 1: Style
 
 Make sure the code style configuration is applied by running PHPCS-Fixer.
 
@@ -40,7 +40,7 @@ Make sure the code style configuration is applied by running PHPCS-Fixer.
 $ composer cs-fix
 ```
 
-### Code Quality (static code analysis)
+### Code Quality 2: Static code analysis
 PHPStan shall be used for static code analysis by running the command below:
 
 ```bash
@@ -51,7 +51,7 @@ $ composer code-check
 $ ./vendor/bin/phpstan analyse
 ```
 
-### Running tests
+### Code Quality 3: Tests
 
 For every implemented feature add unit tests and check all is green by running the command below.
 

phpstan.neon

@@ -1,5 +1,5 @@
 parameters:
-    level: 3
+    level: 4
     paths:
         - src/
         - tests/

src/BigBlueButton.php

@@ -48,7 +48,6 @@
 use BigBlueButton\Responses\HooksCreateResponse;
 use BigBlueButton\Responses\HooksDestroyResponse;
 use BigBlueButton\Responses\HooksListResponse;
-use BigBlueButton\Responses\InsertDocumentResponse;
 use BigBlueButton\Responses\IsMeetingRunningResponse;
 use BigBlueButton\Responses\JoinMeetingResponse;
 use BigBlueButton\Responses\PublishRecordingsResponse;
@@ -74,9 +73,9 @@ class BigBlueButton
     /**
      * BigBlueButton constructor.
      *
-     * @param null       $baseUrl
-     * @param null       $secret
-     * @param null|mixed $opts
+     * @param null|string $baseUrl
+     * @param null|string $secret
+     * @param null|mixed  $opts
      */
     public function __construct($baseUrl = null, $secret = null, $opts = null)
     {
@@ -560,7 +559,7 @@ private function sendRequest($url, $payload = '', $contentType = 'application/xm
     {
         if (extension_loaded('curl')) {
             $ch = curl_init();
-            if (!$ch) {
+            if (!$ch) {  /**  @phpstan-ignore-line */
                 throw new \RuntimeException('Unhandled curl error: ' . curl_error($ch));
             }
 

src/Parameters/CreateMeetingParameters.php

@@ -1431,7 +1431,7 @@ public function getHTTPQuery(): string
             'preUploadedPresentationOverrideDefault' => $this->preUploadedPresentationOverrideDefault,
             'disabledFeatures'                       => join(',', $this->disabledFeatures),
             'disabledFeaturesExclude'                => join(',', $this->disabledFeaturesExclude),
-            'notifyRecordingIsOn'                    => is_null($this->notifyRecordingIsOn) ? ($this->notifyRecordingIsOn ? 'true' : 'false') : $this->notifyRecordingIsOn,
+            'notifyRecordingIsOn'                    => !is_null($this->notifyRecordingIsOn) ? ($this->notifyRecordingIsOn ? 'true' : 'false') : $this->notifyRecordingIsOn,
             'presentationUploadExternalUrl'          => $this->presentationUploadExternalUrl,
             'presentationUploadExternalDescription'  => $this->presentationUploadExternalDescription,
             'recordFullDurationMedia'                => !is_null($this->recordFullDurationMedia) ? ($this->recordFullDurationMedia ? 'true' : 'false') : $this->recordFullDurationMedia,

src/Parameters/DocumentableTrait.php

@@ -36,8 +36,8 @@ public function getPresentations()
     }
 
     /**
-     * @param null  $content
-     * @param null  $filename
+     * @param mixed $content
+     * @param mixed $filename
      * @param mixed $nameOrUrl
      *
      * @return $this

src/Parameters/MetaParameters.php

@@ -56,11 +56,11 @@ public function addMeta($key, $value)
     protected function buildMeta(&$queries)
     {
         if (0 !== count($this->meta)) {
-            foreach ($this->meta as $k => $v) {
-                if (!is_bool($v)) {
-                    $queries['meta_' . $k] = $v;
+            foreach ($this->meta as $key => $value) {
+                if (!is_bool($value)) {
+                    $queries['meta_' . $key] = $value;
                 } else {
-                    $queries['meta_' . $k] = !is_null($v) ? ($v ? 'true' : 'false') : $v;
+                    $queries['meta_' . $key] = $value ? 'true' : 'false';
                 }
             }
         }

src/Parameters/UserDataParameters.php

@@ -56,11 +56,11 @@ public function addUserData($key, $value)
     protected function buildUserData(&$queries)
     {
         if (0 !== count($this->userData)) {
-            foreach ($this->userData as $k => $v) {
-                if (!is_bool($v)) {
-                    $queries['userdata-' . $k] = $v;
+            foreach ($this->userData as $key => $value) {
+                if (!is_bool($value)) {
+                    $queries['userdata-' . $key] = $value;
                 } else {
-                    $queries['userdata-' . $k] = !is_null($v) ? ($v ? 'true' : 'false') : $v;
+                    $queries['userdata-' . $key] = $value ? 'true' : 'false';
                 }
             }
         }