Skip to content

Commit bc3cba2

Browse files
authored
Merge pull request #113 from littleredbutton/add-user-camera-cap
Add userCameraCap (BBB 2.4.5) (fixes #112
2 parents ca1b256 + 91330d6 commit bc3cba2

3 files changed

Lines changed: 40 additions & 1 deletion

File tree

src/Parameters/CreateMeetingParameters.php

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -111,6 +111,8 @@
111111
* @method $this setAllowRequestsWithoutSession(bool $isAllowRequestsWithoutSession)
112112
* @method bool|null isVirtualBackgroundsDisabled()
113113
* @method $this setVirtualBackgroundsDisabled(bool $isVirtualBackgroundsDisabled)
114+
* @method int getUserCameraCap()
115+
* @method $this setUserCameraCap(int $cap)
114116
*
115117
*/
116118
class CreateMeetingParameters extends MetaParameters
@@ -360,6 +362,11 @@ class CreateMeetingParameters extends MetaParameters
360362
*/
361363
protected $virtualBackgroundsDisabled;
362364

365+
/**
366+
* @var int
367+
*/
368+
protected $userCameraCap;
369+
363370
/**
364371
* @var array
365372
*/
@@ -528,6 +535,24 @@ public function isBreakout()
528535
return $this->isBreakout;
529536
}
530537

538+
/**
539+
* @return bool
540+
*/
541+
public function isUserCameraCapDisabled(): bool
542+
{
543+
return $this->userCameraCap === 0;
544+
}
545+
546+
/**
547+
* @return CreateMeetingParameters
548+
*/
549+
public function disableUserCameraCap(): self
550+
{
551+
$this->userCameraCap = 0;
552+
553+
return $this;
554+
}
555+
531556
/**
532557
* @return CreateMeetingParameters
533558
*/

tests/TestCase.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -117,6 +117,7 @@ protected function generateCreateParams()
117117
'breakoutRoomsRecord' => $this->faker->boolean(50),
118118
'allowRequestsWithoutSession' => $this->faker->boolean(50),
119119
'virtualBackgroundsDisabled' => $this->faker->boolean(50),
120+
'userCameraCap' => $this->faker->numberBetween(1, 5),
120121
];
121122
}
122123

@@ -186,7 +187,8 @@ protected function getCreateMock($params)
186187
->setBreakoutRoomsPrivateChatEnabled($params['breakoutRoomsPrivateChatEnabled'])
187188
->setBreakoutRoomsRecord($params['breakoutRoomsRecord'])
188189
->setAllowRequestsWithoutSession($params['allowRequestsWithoutSession'])
189-
->setVirtualBackgroundsDisabled($params['virtualBackgroundsDisabled']);
190+
->setVirtualBackgroundsDisabled($params['virtualBackgroundsDisabled'])
191+
->setUserCameraCap($params['userCameraCap']);
190192
}
191193

192194
/**

tests/unit/Parameters/CreateMeetingParametersTest.php

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -157,4 +157,16 @@ public function testGetPresentationsAsXMLWithFile()
157157
$createMeetingParams->addPresentation('bbb_logo.png', file_get_contents(__DIR__ . DIRECTORY_SEPARATOR . '..' . DIRECTORY_SEPARATOR . '..' . DIRECTORY_SEPARATOR . 'fixtures' . DIRECTORY_SEPARATOR . 'bbb_logo.png'));
158158
$this->assertXmlStringEqualsXmlFile(__DIR__ . DIRECTORY_SEPARATOR . '..' . DIRECTORY_SEPARATOR . '..' . DIRECTORY_SEPARATOR . 'fixtures' . DIRECTORY_SEPARATOR . 'presentation_with_embedded_file.xml', $createMeetingParams->getPresentationsAsXML());
159159
}
160+
161+
public function testUserCameraCap(): void
162+
{
163+
$params = $this->generateCreateParams();
164+
$createMeetingParams = $this->getCreateMock($params);
165+
$this->assertEquals($params['userCameraCap'], $createMeetingParams->getUserCameraCap());
166+
$this->assertFalse($createMeetingParams->isUserCameraCapDisabled());
167+
168+
$createMeetingParams->disableUserCameraCap();
169+
$this->assertEquals(0, $createMeetingParams->getUserCameraCap());
170+
$this->assertTrue($createMeetingParams->isUserCameraCapDisabled());
171+
}
160172
}

0 commit comments

Comments
 (0)