Skip to content

Commit 8bd5bf2

Browse files
committed
Filter out events with no CLDR category mapping
1 parent 69501ac commit 8bd5bf2

File tree

1 file changed

+7
-3
lines changed
  • common/src/main/java/com/box/l10n/mojito/okapi/filters

1 file changed

+7
-3
lines changed

common/src/main/java/com/box/l10n/mojito/okapi/filters/POFilter.java

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -212,17 +212,21 @@ void processNextPluralGroup(Event startGroupEvent) {
212212
? textUnitEvents.get(1).getTextUnit().getSource().toString()
213213
: extractPluralSourceFromSkeleton(startGroupSkeleton);
214214

215+
// Text units whose PO form index has no CLDR mapping (e.g. form 1 for Japanese ONE_FORM)
216+
// are filtered out
217+
List<Event> filteredEvents = new ArrayList<>();
215218
for (int i = 0; i < textUnitEvents.size(); i++) {
216-
ITextUnit textUnit = textUnitEvents.get(i).getTextUnit();
217-
setTextUnitName(textUnit, singularSource);
218219
String cldrForm = poPluralRule.poFormToCldrForm(Integer.toString(i));
219220
if (cldrForm != null) {
221+
ITextUnit textUnit = textUnitEvents.get(i).getTextUnit();
222+
setTextUnitName(textUnit, singularSource);
220223
appendPluralFormToName(textUnit, cldrForm);
224+
filteredEvents.add(textUnitEvents.get(i));
221225
}
222226
}
223227

224228
PluralsHolder pluralsHolder = new PoPluralsHolder(singularSource, pluralSource);
225-
pluralsHolder.loadEvents(textUnitEvents);
229+
pluralsHolder.loadEvents(filteredEvents);
226230
List<Event> completedForms = pluralsHolder.getCompletedForms(targetLocale);
227231

228232
for (Event e : completedForms) {

0 commit comments

Comments
 (0)