refactor(aks): rename shared Key Vault resource

Author: lentidas

examples/aks/locals.tf

@@ -1,7 +1,7 @@
 locals {
   # Parameters for the resources that are created outside this code, but still on the Azure subscription where the DevOps Stack will be deployed.
   default_resource_group         = "YOUR_DEFAULT_RESOURCE_GROUP" # The default resource group where the Key Vault with the Azure AD application credentials is located.
-  default_key_vault              = "YOUR_KEY_VAULT_NAME"         # The name of the Key Vault with the Azure AD application credentials.
+  shared_key_vault_name          = "YOUR_KEY_VAULT_NAME"         # The name of the Key Vault with the Azure AD application credentials.
   oidc_application_name          = "YOUR_APPLICATION_NAME"       # The name of the Azure AD application that will be used for OIDC authentication.  cluster_admins_group_object_id = "38a1908d-0ccd-4acc-99d5-7f0228289752"
   cluster_admins_group_object_id = "YOUR_CLUSTER_ADMINS_GROUP_OBJECT_ID"
 

examples/aks/oidc.tf

@@ -1,18 +1,18 @@
-data "azurerm_key_vault" "default" {
-  name                = local.default_key_vault
+data "azurerm_key_vault" "shared_key_vault" {
+  name                = local.shared_key_vault_name
   resource_group_name = local.default_resource_group
 }
 
 data "azurerm_key_vault_secret" "aad_application_object_id" {
-  key_vault_id = data.azurerm_key_vault.default.id
+  key_vault_id = data.azurerm_key_vault.shared_key_vault.id
   name         = "${local.oidc_application_name}-application-object-id"
 }
 data "azurerm_key_vault_secret" "aad_application_client_id" {
-  key_vault_id = data.azurerm_key_vault.default.id
+  key_vault_id = data.azurerm_key_vault.shared_key_vault.id
   name         = "${local.oidc_application_name}-application-client-id"
 }
 data "azurerm_key_vault_secret" "aad_application_client_secret" {
-  key_vault_id = data.azurerm_key_vault.default.id
+  key_vault_id = data.azurerm_key_vault.shared_key_vault.id
   name         = "${local.oidc_application_name}-application-client-secret"
 }