cmake: we were missing linking against combase.dll

jcelerier · jcelerier · commit 6881d6d62a93 · 2025-07-13T17:11:33.000-04:00
diff --git a/cmake/libremidi.winmidi.cmake b/cmake/libremidi.winmidi.cmake
@@ -73,7 +73,7 @@ target_include_directories(libremidi SYSTEM ${_public}
 )
 target_compile_definitions(libremidi ${_public} LIBREMIDI_WINMIDI)
 set(LIBREMIDI_HAS_WINMIDI 1)
-target_link_libraries(libremidi ${_public} RuntimeObject)
+target_link_libraries(libremidi ${_public} RuntimeObject Combase)
 if(MSVC)
   target_link_libraries(libremidi ${_public} windowsapp)
 endif()
diff --git a/cmake/libremidi.winuwp.cmake b/cmake/libremidi.winuwp.cmake
@@ -19,7 +19,7 @@ if(CPPWINRT_PATH)
 
   target_include_directories(libremidi SYSTEM ${_public} "${CPPWINRT_PATH}")
   target_compile_definitions(libremidi ${_public} LIBREMIDI_WINUWP)
-  target_link_libraries(libremidi INTERFACE RuntimeObject)
+  target_link_libraries(libremidi INTERFACE RuntimeObject Combase)
   # We don't need /ZW option here (support for C++/CX)' as we use C++/WinRT
   if(MSVC)
     target_compile_options(libremidi ${_public} /EHsc)

Original file line number	Diff line number	Diff line change
`@@ -73,7 +73,7 @@ target_include_directories(libremidi SYSTEM ${_public}`
`73`	`73`	`)`
`74`	`74`	`target_compile_definitions(libremidi ${_public} LIBREMIDI_WINMIDI)`
`75`	`75`	`set(LIBREMIDI_HAS_WINMIDI 1)`
`76`		`-target_link_libraries(libremidi ${_public} RuntimeObject)`
	`76`	`+target_link_libraries(libremidi ${_public} RuntimeObject Combase)`
`77`	`77`	`if(MSVC)`
`78`	`78`	`target_link_libraries(libremidi ${_public} windowsapp)`
`79`	`79`	`endif()`