now using custom matchers; switched to filtering queries, not errors for consistency

Author: jspaaks

src/components/AuthorCardViewing.vue

@@ -47,7 +47,7 @@ import { computed, defineComponent, onUpdated, PropType } from 'vue'
 import { AuthorType } from 'src/types'
 import { useStepperErrors } from 'src/store/stepper-errors'
 import { useValidation } from 'src/store/validation'
-import { byError, byDuplicateAuthor, emailQueries, orcidQueries } from 'src/error-filtering'
+import { byError, duplicateAuthorMatcher, duplicateAuthorQueries, emailQueries, orcidQueries } from 'src/error-filtering'
 
 export default defineComponent({
     name: 'AuthorCardViewing',
@@ -82,7 +82,9 @@ export default defineComponent({
                 .map(query => query.replace.message)
         })
         const duplicateErrors = computed(() => {
-            return errors.value.filter(byDuplicateAuthor(props.index)).map(() => 'This author is a duplicate.')
+            return duplicateAuthorQueries
+                .filter(byError(errors.value, duplicateAuthorMatcher(props.index)))
+                .map(query => query.replace.message)
         })
         const authorErrors = computed(() => [...emailErrors.value, ...orcidErrors.value, ...duplicateErrors.value])
         return {

src/components/IdentifierCardViewing.vue

@@ -45,7 +45,7 @@
 import { computed, defineComponent, PropType } from 'vue'
 import { IdentifierType } from 'src/types'
 import { useValidation } from 'src/store/validation'
-import { byError, byDuplicateIdentifier, identifierValueQueries } from 'src/error-filtering'
+import { byError, duplicateIdentifierMatcher, duplicateIdentifierQueries, identifierValueQueries } from 'src/error-filtering'
 
 export default defineComponent({
     name: 'IdentifierCardViewing',
@@ -71,7 +71,9 @@ export default defineComponent({
                 .map(query => query.replace.message)
         })
         const duplicateErrors = computed(() => {
-            return errors.value.filter(byDuplicateIdentifier(props.index)).map(() => 'This identifier is a duplicate.')
+            return duplicateIdentifierQueries
+                .filter(byError(errors.value, duplicateIdentifierMatcher(props.index)))
+                .map(query => query.replace.message)
         })
         const identifierErrors = computed(() => [...identifierValueErrors.value, ...duplicateErrors.value])
         return {

src/components/Keyword.vue

@@ -46,7 +46,7 @@
 <script lang="ts">
 import { computed, defineComponent } from 'vue'
 import { useValidation } from 'src/store/validation'
-import { byError, byDuplicateKeyword, keywordQueries } from 'src/error-filtering'
+import { byError, duplicateKeywordMatcher, duplicateKeywordQueries, keywordQueries } from 'src/error-filtering'
 
 export default defineComponent({
     name: 'Keyword',
@@ -72,7 +72,9 @@ export default defineComponent({
                 .map(query => query.replace.message)
         })
         const duplicateErrors = computed(() => {
-            return errors.value.filter(byDuplicateKeyword(props.index)).map(() => 'This keyword is a duplicate.')
+            return duplicateKeywordQueries
+                .filter(byError(errors.value, duplicateKeywordMatcher(props.index)))
+                .map(query => query.replace.message)
         })
         const validationErrors = computed(() => [...keywordErrors.value, ...duplicateErrors.value])
         return {

src/error-filtering.ts

@@ -30,7 +30,7 @@ const defaultMatcher: Comparator = (error, query) => {
     return true
 }
 
-export const byDuplicateAuthor = (index: number) => {
+export const duplicateAuthorMatcher = (index: number) => {
     return (error: ErrorObject) => {
         if (error.instancePath !== '/authors') {
             return false
@@ -45,7 +45,7 @@ export const byDuplicateAuthor = (index: number) => {
     }
 }
 
-export const byDuplicateIdentifier = (index: number) => {
+export const duplicateIdentifierMatcher = (index: number) => {
     return (error: ErrorObject) => {
         if (error.instancePath !== '/identifiers') {
             return false
@@ -60,7 +60,7 @@ export const byDuplicateIdentifier = (index: number) => {
     }
 }
 
-export const byDuplicateKeyword = (index: number) => {
+export const duplicateKeywordMatcher = (index: number) => {
     return (error: ErrorObject) => {
         if (error.instancePath !== '/keywords') {
             return false
@@ -110,6 +110,27 @@ export const dateReleasedQueries: ErrorQuery[] = [{
     }
 }]
 
+export const duplicateAuthorQueries: ErrorQuery[] = [{
+    find: {},
+    replace: {
+        message: 'This author is a duplicate.'
+    }
+}]
+
+export const duplicateIdentifierQueries: ErrorQuery[] = [{
+    find: {},
+    replace: {
+        message: 'This identifier is a duplicate.'
+    }
+}]
+
+export const duplicateKeywordQueries: ErrorQuery[] = [{
+    find: {},
+    replace: {
+        message: 'This keyword is a duplicate.'
+    }
+}]
+
 export const emailQueries = (index: number) => {
     return [{
         find: {