Make Authors not optional in CffType

Author: abelsiqueira

src/components/ScreenAuthors.vue

@@ -107,40 +107,27 @@ export default defineComponent({
         const { errors } = useValidation()
         const editingId = ref(0)
         const addAuthor = async () => {
-            let newAuthors:AuthorType[]
             const newAuthor: AuthorType = {}
-            if (authors.value === undefined) {
-                newAuthors = [newAuthor]
-            } else {
-                newAuthors = [...authors.value, newAuthor]
-            }
+            const newAuthors = [...authors.value, newAuthor]
             setAuthors(newAuthors)
             editingId.value = newAuthors.length - 1
             // await the DOM update that resulted from updating the authors list
             await nextTick()
             scrollToBottom()
         }
         const removeAuthor = () => {
-            if (authors.value !== undefined) {
-                const newAuthors = [...authors.value]
-                newAuthors.splice(editingId.value, 1)
-                setAuthors(newAuthors)
-                editingId.value = -1
-                if (Array.isArray(newAuthors) && newAuthors.length === 0) {
-                    setAuthors([])
-                }
-            }
+            const newAuthors = [...authors.value]
+            newAuthors.splice(editingId.value, 1)
+            setAuthors(newAuthors)
+            editingId.value = -1
         }
         const setAuthorField = (field: keyof AuthorType, value: string) => {
-            if (authors.value !== undefined) {
-                const author = { ...authors.value[editingId.value] }
-                author[field] = value === '' ? undefined : value
-                authors.value[editingId.value] = author
-                setAuthors(authors.value)
-            }
+            const author = { ...authors.value[editingId.value] }
+            author[field] = value === '' ? undefined : value
+            authors.value[editingId.value] = author
+            setAuthors(authors.value)
         }
         const moveAuthorUp = (index: number) => {
-            if (authors.value === undefined) return
             moveUp(index, authors.value, setAuthors)
             if (editingId.value === index && index > 0) {
                 editingId.value = editingId.value - 1
@@ -149,7 +136,6 @@ export default defineComponent({
             }
         }
         const moveAuthorDown = (index: number) => {
-            if (authors.value === undefined) return
             moveDown(index, authors.value, setAuthors)
             if (editingId.value === index && index < authors.value.length - 1) {
                 editingId.value = editingId.value + 1

src/store/cff.ts

@@ -43,7 +43,7 @@ export function useCff () {
         url: computed(() => cff.value.url),
         version: computed(() => cff.value.version),
         setAbstract: (newAbstract: string) => { cff.value.abstract = newAbstract === '' ? undefined : newAbstract },
-        setAuthors: (newAuthors: AuthorsType) => { cff.value.authors = newAuthors === [] ? undefined : newAuthors },
+        setAuthors: (newAuthors: AuthorsType) => { cff.value.authors = newAuthors },
         setCommit: (newCommit: string) => { cff.value.commit = newCommit === '' ? undefined : newCommit },
         setDateReleased: (newDateReleased: string) => { cff.value.dateReleased = newDateReleased === '' ? undefined : newDateReleased },
         setIdentifiers: (newIdentifiers: IdentifiersType) => { cff.value.identifiers = newIdentifiers === [] ? undefined : newIdentifiers },

src/types/index.ts

@@ -8,7 +8,7 @@ export type AuthorType = {
     email?: string;
 }
 
-export type AuthorsType = Array<AuthorType> | undefined
+export type AuthorsType = Array<AuthorType>
 
 export type IdentifierTypeType = 'doi' | 'url' | 'swh' | 'other'
 export type IdentifierType = {
@@ -25,7 +25,7 @@ export type TypeType = 'software' | 'dataset'
 
 export type CffType = {
     abstract?: string,
-    authors?: AuthorsType,
+    authors: AuthorsType,
     cffVersion: string,
     commit?: string,
     dateReleased?: string,