Skip to content

Commit 8928e5f

Browse files
Apply suggestions from code review
Co-authored-by: Abel Soares Siqueira <abel.s.siqueira@gmail.com>
1 parent 4afbed2 commit 8928e5f

2 files changed

Lines changed: 12 additions & 16 deletions

File tree

CONTRIBUTING.md

Lines changed: 10 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -12,32 +12,30 @@ The sections below outline the steps in each case.
1212

1313
## You have a question
1414

15-
1615
- use the search functionality [here](https://github.com/citation-file-format/cff-initializer-javascript/issues) to see if someone already filed the same issue;
1716
- if your issue search did not yield any relevant results, make a new issue;
18-
- apply the "Question" label; apply other labels when relevant.
1917

2018
## You think you may have found a bug
2119

22-
2320
- use the search functionality [here](https://github.com/citation-file-format/cff-initializer-javascript/issues) to see if someone already filed the same issue;
2421
- if your issue search did not yield any relevant results, make a new issue, making sure to provide enough information to the rest of the community to understand the cause and context of the problem. Depending on the issue, you may want to include:
25-
- the [SHA hashcode](https://help.github.com/articles/autolinked-references-and-urls/#commit-shas) of the commit that is causing your problem;
22+
- the version of cffinit (bottom right in the app);
23+
- if you are using a development version, the [SHA hashcode](https://help.github.com/articles/autolinked-references-and-urls/#commit-shas) of the commit that is causing your problem;
2624
- some identifying information (name and version number) for dependencies you're using;
2725
- information about the operating system;
28-
- apply relevant labels to the newly created issue.
2926

3027
## You want to make some kind of change to the code base
3128

32-
3329
- (**important**) announce your plan to the rest of the community *before you start working*. This announcement should be in the form of a (new) issue;
34-
- (**important**) wait until some kind of consensus is reached about your idea being a good idea;
35-
- if needed, fork the repository to your own Github profile and create your own feature branch off of the latest master commit. While working on your feature branch, make sure to stay up to date with the master branch by pulling in changes, possibly from the 'upstream' repository (follow the instructions [here](https://help.github.com/articles/configuring-a-remote-for-a-fork/) and [here](https://help.github.com/articles/syncing-a-fork/);
36-
- make sure the existing unit tests still work by running ``npm run test:unit:ci``;
37-
- make sure all the workflows (Github Action) pass;
30+
- (**important**) wait until some kind of consensus is reached about your idea being implemented;
31+
- if needed, fork the repository to your own Github profile and create your own feature branch off of the latest main commit. While working on your feature branch, make sure to stay up to date with the main branch by pulling in changes, possibly from the 'upstream' repository (follow the instructions [here](https://help.github.com/articles/configuring-a-remote-for-a-fork/) and [here](https://help.github.com/articles/syncing-a-fork/);
32+
- read the [developer documentation](README.dev.md);
33+
- make sure the existing tests still work;
3834
- add your own tests (if necessary);
3935
- update or expand the developer documentation;
4036
- [push](http://rogerdudler.github.io/git-guide/) your feature branch to (your fork of) the cff-initializer-javascript repository on GitHub;
41-
- create the pull request, e.g. following the instructions [here](https://help.github.com/articles/creating-a-pull-request/).
37+
- create the pull request, e.g. following the instructions [here](https://help.github.com/articles/creating-a-pull-request/);
38+
- verify that the GitHub workflows passed (if they don't, mark the PR as a draft while you fix it);
39+
- don't request reviews, the reviewer will assign them themselves.
4240

43-
In case you feel like you've made a valuable contribution, but you don't know how to write or run tests for it, or how to generate the documentation: don't let this discourage you from making the pull request; we can help you! Just go ahead and submit the pull request, but keep in mind that you might be asked to append additional commits to your pull request.
41+
If you don't know how to write or run tests or generate documentation, don't let this discourage you; we can help! Ask for help on the relevant issue so we can decide how to proceed.

README.md

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,18 +2,16 @@
22

33
[![Build](https://github.com/citation-file-format/cff-initializer-javascript/actions/workflows/ghpages.yml/badge.svg)](https://github.com/citation-file-format/cff-initializer-javascript/actions/workflows/ghpages.yml)
44
[![Lint](https://github.com/citation-file-format/cff-initializer-javascript/actions/workflows/lint.yml/badge.svg)](https://github.com/citation-file-format/cff-initializer-javascript/actions/workflows/lint.yml)
5-
[![Preview](https://github.com/citation-file-format/cff-initializer-javascript/actions/workflows/preview.yml/badge.svg)](https://github.com/citation-file-format/cff-initializer-javascript/actions/workflows/preview.yml)
6-
[![Publish](https://github.com/citation-file-format/cff-initializer-javascript/actions/workflows/publish.yml/badge.svg)](https://github.com/citation-file-format/cff-initializer-javascript/actions/workflows/publish.yml)
75
[![Test](https://github.com/citation-file-format/cff-initializer-javascript/actions/workflows/test.yml/badge.svg)](https://github.com/citation-file-format/cff-initializer-javascript/actions/workflows/test.yml)
8-
[![cffconvert](https://github.com/citation-file-format/cff-initializer-javascript/actions/workflows/cffconvert.yml/badge.svg)](https://github.com/citation-file-format/cff-initializer-javascript/actions/workflows/cffconvert.yml)
9-
[![zenodraft](https://github.com/citation-file-format/cff-initializer-javascript/actions/workflows/zenodraft.yml/badge.svg)](https://github.com/citation-file-format/cff-initializer-javascript/actions/workflows/zenodraft.yml)
106

117
# cffinit: a web application to create CITATION.cff files
128

139
## What cffinit can do for you?
10+
1411
When you made some software and you want to include instructions on how to cite it, CITATION.cff files are the answer. However, sometimes it's tricky to ensure you write valid CFF. This tool helps mitigate that problem by generating the CFF text using a web form with form validation and user feedback.
1512

1613
## Information for users
14+
1715
- Check out the **live version** at <https://citation-file-format.github.io/cff-initializer-javascript/>.
1816
- For the rationale behind CITATION.cff files, you can read more here:
1917
- <https://www.software.ac.uk/blog/2017-12-12-standard-format-citation-files>.

0 commit comments

Comments
 (0)