Skip to content

Commit c378c4b

Browse files
committed
Add hardcode version numbers on the footer of the app and the landing page
1 parent 781301e commit c378c4b

3 files changed

Lines changed: 23 additions & 16 deletions

File tree

README.dev.md

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -123,10 +123,12 @@ This section describes how to make a release in 2 parts:
123123
1. Verify that the information in `CITATION.cff` is correct
124124
2. Generate an updated version of `.zenodo.json` if needed using `cffconvert`
125125
3. Make sure the version field in `package.json` is correct
126-
4. By running `npm run lint` make sure the linter does not complain
127-
5. Run the unit tests with `npm run test:unit:ci`
128-
6. Make sure that github.io page is up to date
129-
7. Check whether the [Publish](https://github.com/citation-file-format/cff-initializer-javascript/actions/workflows/publish.yml) workflow worked recently and it was successful
126+
4. Update the version in the [landing page footer](src/components/LayoutLanding.vue).
127+
5. Update the version in the [app footer](src/components/Footer.vue).
128+
6. By running `npm run lint` make sure the linter does not complain
129+
7. Run the unit tests with `npm run test:unit:ci`
130+
8. Make sure that github.io page is up to date
131+
9. Check whether the [Publish](https://github.com/citation-file-format/cff-initializer-javascript/actions/workflows/publish.yml) workflow worked recently and it was successful
130132

131133
### (2/2) GitHub
132134

src/components/Footer.vue

Lines changed: 14 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,19 @@
11
<template>
2-
<div id="logo">
3-
<a
4-
href="https://esciencecenter.nl"
5-
target="_blank"
2+
<div class="row">
3+
<div
4+
id="logo"
5+
class="col"
66
>
7-
<img src="~assets/nlesc-logo.svg">
8-
</a>
7+
<a
8+
href="https://esciencecenter.nl"
9+
target="_blank"
10+
>
11+
<img src="~assets/nlesc-logo.svg">
12+
</a>
13+
</div>
14+
<span class="col text-right text-white text-body1 text-bold">
15+
Version 2.0.0
16+
</span>
917
</div>
1018
</template>
1119

src/components/LayoutLanding.vue

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -47,23 +47,20 @@
4747
/>
4848
</div>
4949
</div>
50+
<span class="text-right text-black text-body1 text-bold">
51+
Version 2.0.0
52+
</span>
5053
</div>
51-
<Footer />
5254
</div>
5355
</template>
5456

5557
<script lang="ts">
56-
import Footer from 'components/Footer.vue'
5758
5859
import { defineComponent } from 'vue'
5960
6061
export default defineComponent({
6162
name: 'LayoutLanding',
6263
63-
components: {
64-
Footer
65-
},
66-
6764
setup () {
6865
return {
6966
}

0 commit comments

Comments
 (0)