Skip to content

Commit 4ecc58a

Browse files
committed
Use no-op logger default instead of empty object cast
1 parent 4d7d708 commit 4ecc58a

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

providers/summary/scancode/legacy-summarizer.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,10 @@ export class ScanCodeLegacySummarizer {
3636
declare options: SummarizerOptions
3737
declare logger: Logger
3838

39-
constructor(options: SummarizerOptions = {} as SummarizerOptions, logger: Logger = {} as Logger) {
39+
constructor(
40+
options: SummarizerOptions = {} as SummarizerOptions,
41+
logger: Logger = { info: () => {}, warn: () => {}, error: () => {}, debug: () => {}, log: () => {} }
42+
) {
4043
this.options = options
4144
this.logger = logger
4245
}

providers/summary/scancode/new-summarizer.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,10 @@ export class ScanCodeNewSummarizer {
3636
declare options: SummarizerOptions
3737
declare logger: Logger
3838

39-
constructor(options: SummarizerOptions = {} as SummarizerOptions, logger: Logger = {} as Logger) {
39+
constructor(
40+
options: SummarizerOptions = {} as SummarizerOptions,
41+
logger: Logger = { info: () => {}, warn: () => {}, error: () => {}, debug: () => {}, log: () => {} }
42+
) {
4043
this.options = options
4144
this.logger = logger
4245
}

0 commit comments

Comments
 (0)