Skip to content
This repository was archived by the owner on Jun 2, 2021. It is now read-only.

Commit 21e7902

Browse files
Change error type to Bad request when message is invalid
[#171670120](https://www.pivotaltracker.com/story/show/171670120)
1 parent 28cb31c commit 21e7902

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

app/controllers/v3/service_instances_controller.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -202,7 +202,7 @@ def create_managed(message, space:)
202202

203203
def update_user_provided(service_instance)
204204
message = ServiceInstanceUpdateUserProvidedMessage.new(hashed_params[:body])
205-
invalid_param!(message.errors.full_messages) unless message.valid?
205+
bad_request!(message.errors.full_messages) unless message.valid?
206206

207207
service_event_repository = VCAP::CloudController::Repositories::ServiceEventRepository::WithUserActor.new(user_audit_info)
208208
service_instance = ServiceInstanceUpdateUserProvided.new(service_event_repository).update(service_instance, message)
@@ -211,7 +211,7 @@ def update_user_provided(service_instance)
211211

212212
def update_managed(service_instance)
213213
message = ServiceInstanceUpdateManagedMessage.new(hashed_params[:body])
214-
invalid_param!(message.errors.full_messages) unless message.valid?
214+
bad_request!(message.errors.full_messages) unless message.valid?
215215

216216
if message.service_plan_guid
217217
service_plan = ServicePlan.first(guid: message.service_plan_guid)

0 commit comments

Comments
 (0)