Update rubocop to 0.80.1

Authored-by: Greg Cobb <gcobb@pivotal.io>

Author: Gerg

.rubocop.yml

@@ -193,9 +193,6 @@ Style/Alias:
 Style/BlockDelimiters:
   Enabled: false
 
-Style/BracesAroundHashParameters:
-  Enabled: false
-
 Style/ClassAndModuleChildren:
   Enabled: false
 
@@ -300,3 +297,12 @@ Style/TrivialAccessors:
 
 Style/WordArray:
   Enabled: false
+
+Style/HashEachMethods:
+  Enabled: false
+
+Style/HashTransformKeys:
+  Enabled: true
+
+Style/HashTransformValues:
+  Enabled: true

Gemfile

@@ -88,7 +88,7 @@ group :test do
   gem 'rspec-rails', '~> 3.9.1'
   gem 'rspec-wait'
   gem 'rspec_api_documentation', '>= 6.1.0'
-  gem 'rubocop', '~> 0.79.0'
+  gem 'rubocop', '~> 0.80.1'
   gem 'timecop'
   gem 'webmock', '> 2.3.1'
 end

Gemfile.lock

@@ -305,7 +305,7 @@ GEM
     parallel (1.19.2)
     parallel_tests (3.3.0)
       parallel
-    parser (2.7.1.5)
+    parser (2.7.2.0)
       ast (~> 2.4.1)
     pg (1.2.3)
     posix-spawn (0.3.15)
@@ -356,6 +356,7 @@ GEM
     retryable (3.0.5)
     reverse_markdown (2.0.0)
       nokogiri
+    rexml (3.2.4)
     rfc822 (0.1.5)
     roodi (5.0.0)
       ruby_parser (~> 3.2, >= 3.2.2)
@@ -393,11 +394,12 @@ GEM
       activesupport (>= 3.0.0)
       mustache (~> 1.0, >= 0.99.4)
       rspec (~> 3.0)
-    rubocop (0.79.0)
+    rubocop (0.80.1)
       jaro_winkler (~> 1.5.1)
       parallel (~> 1.10)
       parser (>= 2.7.0.1)
       rainbow (>= 2.2.2, < 4.0)
+      rexml
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 1.4.0, < 1.7)
     ruby-debug-ide (0.7.2)
@@ -561,7 +563,7 @@ DEPENDENCIES
   rspec-rails (~> 3.9.1)
   rspec-wait
   rspec_api_documentation (>= 6.1.0)
-  rubocop (~> 0.79.0)
+  rubocop (~> 0.80.1)
   ruby-debug-ide (>= 0.7.0.beta4)
   rubyzip (>= 1.3.0)
   scientist (~> 1.1.0)

app/messages/base_message.rb

@@ -68,7 +68,7 @@ def self.from_params(params, to_array_keys, fields: [])
 
       fields.each do |key|
         if opts[key].is_a?(Hash)
-          opts[key].keys.each do |attribute|
+          opts[key].each_key do |attribute|
             to_array! opts[key], attribute
           end
         end

app/presenters/v3/revision_presenter.rb

@@ -57,7 +57,7 @@ def build_links
         end
 
         def processes
-          revision.commands_by_process_type.map { |k, v| [k, { 'command' => v }] }.to_h
+          revision.commands_by_process_type.transform_values { |v| { 'command' => v } }
         end
 
         def sidecars

lib/cloud_controller/uaa/uaa_client.rb

@@ -45,7 +45,7 @@ def users_for_ids(user_ids)
     end
 
     def usernames_for_ids(user_ids)
-      fetch_users(user_ids).map { |id, user| [id, user['username']] }.to_h
+      fetch_users(user_ids).transform_values { |user| user['username'] }
     rescue UaaUnavailable, CF::UAA::UAAError => e
       logger.error("Failed to retrieve usernames from UAA: #{e.inspect}")
       {}

lib/tasks/db.rake

@@ -21,13 +21,13 @@ namespace :db do
           end
         end
       RUBY
-      puts'*' * 134
-      puts''
+      puts '*' * 134
+      puts ''
       puts "The migration is in #{File.join(migrations_dir, filename)}"
       puts ''
       puts 'Before writing a migration review our style guide: https://github.com/cloudfoundry/cloud_controller_ng/wiki/CAPI-Migration-Style-Guide'
-      puts''
-      puts'*' * 134
+      puts ''
+      puts '*' * 134
     end
   end