v3(services): Respect plan max_polling_duration when creating route bindings

[#174398273](https://www.pivotaltracker.com/story/show/174398273)

Author: pivotal-marcela-campo

app/jobs/v3/create_route_binding_job.rb

@@ -38,11 +38,12 @@ def resource_type
       end
 
       def perform
-        precursor = RouteBinding.first(guid: @precursor_guid)
+        precursor = route_binding
         gone! unless precursor
 
         service_event_repository = VCAP::CloudController::Repositories::ServiceEventRepository::WithUserActor.new(@user_audit_info)
         action = V3::ServiceRouteBindingCreate.new(service_event_repository)
+        compute_maximum_duration
 
         if @first_time
           @first_time = false
@@ -67,6 +68,15 @@ def perform
 
       private
 
+      def route_binding
+        RouteBinding.first(guid: @precursor_guid)
+      end
+
+      def compute_maximum_duration
+        max_poll_duration_on_plan = route_binding.service_instance.service_plan.try(:maximum_polling_duration)
+        self.maximum_duration_seconds = max_poll_duration_on_plan
+      end
+
       def gone!
         raise CloudController::Errors::ApiError.new_from_details('ResourceNotFound', "The binding could not be found: #{@precursor_guid}")
       end

spec/unit/jobs/v3/create_route_binding_job_spec.rb

@@ -9,7 +9,8 @@ module V3
 
       let(:space) { Space.make }
       let(:service_offering) { Service.make(requires: ['route_forwarding']) }
-      let(:service_plan) { ServicePlan.make(service: service_offering) }
+      let(:maximum_polling_duration) { nil }
+      let(:service_plan) { ServicePlan.make(service: service_offering, maximum_polling_duration: maximum_polling_duration) }
       let(:service_instance) { ManagedServiceInstance.make(service_plan: service_plan, space: space) }
       let(:route) { Route.make(space: space) }
       let(:state) { 'in progress' }
@@ -66,6 +67,26 @@ module V3
           end
 
           context 'asynchronous response' do
+            context 'computes the maximum duration' do
+              before do
+                TestConfig.override({
+                  broker_client_max_async_poll_duration_minutes: 90009
+                })
+                subject.perform
+              end
+
+              it 'sets to the default value' do
+                expect(subject.maximum_duration_seconds).to eq(90009.minutes)
+              end
+
+              context 'when the plan defines a duration' do
+                let(:maximum_polling_duration) { 7465 }
+
+                it 'sets to the plan value' do
+                  expect(subject.maximum_duration_seconds).to eq(7465)
+                end
+              end
+            end
             it 'calls bind and then poll' do
               subject.perform
 
@@ -129,6 +150,27 @@ module V3
               expect(subject.finished).to be_truthy
             end
           end
+
+          context 'the maximum duration' do
+            it 'recomputes the value' do
+              subject.maximum_duration_seconds = 90009
+              TestConfig.override({ broker_client_max_async_poll_duration_minutes: 8088 })
+              subject.perform
+              expect(subject.maximum_duration_seconds).to eq(8088.minutes)
+            end
+
+            context 'when the plan value changes between calls' do
+              before do
+                subject.maximum_duration_seconds = 90009
+                service_plan.update(maximum_polling_duration: 5000)
+                subject.perform
+              end
+
+              it 'sets to the new plan value' do
+                expect(subject.maximum_duration_seconds).to eq(5000)
+              end
+            end
+          end
         end
 
         context 'retry interval' do