v3(bindings): can create bindings with params (cloudfoundry#1904)

[#175203762](https://www.pivotaltracker.com/story/show/175203762)

Author: Derik Evangelista

app/models/services/service_binding.rb

@@ -152,7 +152,7 @@ def save_with_attributes_and_new_operation(attributes, operation)
     def save_with_new_operation(last_operation, attributes: {})
       ServiceBinding.db.transaction do
         self.lock!
-        set(attributes)
+        set(attributes.except(:parameters, :route_services_url, :endpoints))
         save_changes
 
         if self.last_operation

spec/request/service_credential_bindings_spec.rb

@@ -1307,11 +1307,15 @@ def check_filtered_bindings(*bindings)
             let(:state) { 'succeeded' }
             let(:fetch_binding_status_code) { 200 }
             let(:syslog_drain_url) { 'http://syslog.example.com/wow' }
+            let(:route_service_url) { 'http://route.example.com/wow' }
             let(:credentials) { { password: 'foo' } }
+            let(:parameters) { { foo: 'bar', another_foo: 'another_bar' } }
+
             let(:fetch_binding_body) do
               {
                 syslog_drain_url: syslog_drain_url,
-                credentials: credentials
+                credentials: credentials,
+                parameters: parameters
               }
             end
 
@@ -1338,6 +1342,13 @@ def check_filtered_bindings(*bindings)
               expect(job.state).to eq(VCAP::CloudController::PollableJobModel::COMPLETE_STATE)
             end
 
+            it 'updates the binding details with the fetch binding response' do
+              execute_all_jobs(expected_successes: 1, expected_failures: 0)
+
+              expect(binding.reload.syslog_drain_url).to eq(syslog_drain_url)
+              expect(binding.credentials).to eq(credentials.with_indifferent_access)
+            end
+
             context 'fetching binding fails ' do
               let(:fetch_binding_status_code) { 404 }
               let(:fetch_binding_body) {}

spec/unit/models/services/service_binding_spec.rb

@@ -498,22 +498,54 @@ def new_model
       end
 
       context 'when attributes are passed in' do
-        it 'updates the attributes' do
-          last_operation = {
-            state: 'in progress',
-            type: 'create',
-            description: '10%'
+        let(:credentials) { { password: 'rice' } }
+        let(:syslog_drain_url) { 'http://foo.example.com/bar' }
+        let(:volume_mounts) { [{
+          container_dir: '/var/vcap/data/153e3c4b-1151-4cf7-b311-948dd77fce64',
+          device_type: 'shared',
+          mode: 'rw'
+        }.with_indifferent_access]
+        }
+        let(:attributes) {
+          {
+            name: 'gohan',
+            credentials: credentials,
+            syslog_drain_url: syslog_drain_url,
+            volume_mounts: volume_mounts
           }
-          attributes = { name: 'gohan', credentials: { password: 'rice' } }
-          binding.save_with_new_operation(last_operation, attributes: attributes)
+        }
+        let(:last_operation) { {
+          state: 'in progress',
+          type: 'create',
+          description: '10%'
+        }
+        }
 
+        it 'updates the attributes' do
+          binding.save_with_new_operation(last_operation, attributes: attributes)
+          binding.reload
           expect(binding.last_operation.state).to eq 'in progress'
           expect(binding.last_operation.description).to eq '10%'
           expect(binding.last_operation.type).to eq 'create'
           expect(binding.name).to eq 'gohan'
-          expect(binding.credentials).to eq({ 'password' => 'rice' })
+          expect(binding.credentials).to eq(credentials.with_indifferent_access)
+          expect(binding.syslog_drain_url).to eq('http://foo.example.com/bar')
+          expect(binding.volume_mounts).to eq(volume_mounts)
           expect(ServiceBinding.count).to eq(1)
         end
+
+        it 'only saves permitted attributes' do
+          expect {
+            binding.save_with_new_operation(last_operation, attributes: attributes.merge(
+              parameters: {
+                foo: 'bar',
+                ding: 'dong'
+              },
+              endpoints: [{ host: 'mysqlhost', ports: ['3306'] }],
+              route_services_url: 'http://route.example.com'
+          ))
+          } .not_to raise_error
+        end
       end
     end