v3(tests): Enhanced Bindings Orphan mitigation tests

[#174878594](https://www.pivotaltracker.com/story/show/174878594)

Author: pivotal-marcela-campo

spec/request/service_route_bindings_spec.rb

@@ -686,30 +686,6 @@
               'request' => request.with_indifferent_access
             })
           end
-
-          context 'orphan mitigation' do
-            it_behaves_like 'create binding orphan mitigation' do
-              let(:bind_url) { broker_bind_url }
-              let(:plan_id) { plan.unique_id }
-              let(:offering_id) { offering.unique_id }
-              let(:client_body) do
-                {
-                  context: {
-                    platform: 'cloudfoundry',
-                    organization_guid: org.guid,
-                    organization_name: org.name,
-                    space_guid: space.guid,
-                    space_name: space.name,
-                  },
-                  service_id: service_instance.service_plan.service.unique_id,
-                  plan_id: service_instance.service_plan.unique_id,
-                  bind_resource: {
-                    route: route.uri,
-                  },
-                }
-              end
-            end
-          end
         end
 
         context 'when the binding completes asynchronously' do
@@ -860,6 +836,30 @@
             end
           end
         end
+
+        context 'orphan mitigation' do
+          it_behaves_like 'create binding orphan mitigation' do
+            let(:bind_url) { broker_bind_url }
+            let(:plan_id) { plan.unique_id }
+            let(:offering_id) { offering.unique_id }
+            let(:client_body) do
+              {
+                context: {
+                  platform: 'cloudfoundry',
+                  organization_guid: org.guid,
+                  organization_name: org.name,
+                  space_guid: space.guid,
+                  space_name: space.name,
+                },
+                service_id: service_instance.service_plan.service.unique_id,
+                plan_id: service_instance.service_plan.unique_id,
+                bind_resource: {
+                  route: route.uri,
+                },
+              }
+            end
+          end
+        end
       end
 
       describe 'permissions' do

spec/support/shared_examples/request/bindings_orphan_mitigation.rb

@@ -16,14 +16,18 @@
         body: client_body).to_return(status: broker_bind_status_code, body: bind_response_body)
   end
 
-  context 'should not be performed' do
-    before do
-      stub_request(:get, "#{bind_url}/last_operation").
-        with({ query: { plan_id: plan_id, service_id: offering_id } }).
-        to_return(status: 200, body: '{"state": "in progress"}')
-    end
+  after do
+      WebMock.reset!
+  end
 
+  context 'should not be performed' do
     context 'broker returns valid 200, 201, 202' do
+      before do
+        stub_request(:get, "#{bind_url}/last_operation").
+          with({ query: { plan_id: plan_id, service_id: offering_id } }).
+          to_return(status: 200, body: '{}')
+      end
+
       [200, 201, 202].each do |code|
         context "response is #{code}" do
           let(:broker_bind_status_code) { code }
@@ -48,13 +52,9 @@
       end
     end
 
-    context 'response for last operation is 200 state failed' do
-      let(:broker_bind_status_code) { 202 }
-      before do
-        stub_request(:get, "#{bind_url}/last_operation").
-          with({ query: { plan_id: plan_id, service_id: offering_id } }).
-          to_return(status: 200, body: '{"state": "failed"}')
-      end
+    context 'response is 422 with known reason' do
+      let(:broker_bind_status_code) { 422 }
+      let(:bind_response_body) { '{ "error": "ConcurrencyError", "description": "some description" }' }
 
       it 'fails the job and does not perform orphan mitigation' do
         execute_all_jobs(expected_successes: 0, expected_failures: 1)
@@ -65,10 +65,10 @@
     end
 
     context 'broker returns a 4xx code' do
-      [400, 401, 408, 409, *411..431].each do |code|
+      [400, 401, 408, 409, *411..421, *423..431].each do |code|
         context "response is #{code}" do
           let(:broker_bind_status_code) { code }
-          let(:bind_response_body) { '{ "error": "ConcurrencyError", "description": "some description" }' }
+          let(:bind_response_body) { '{ "error": "some 4xx error", "description": "some description" }' }
 
           it 'fails the job and updates the binding and job' do
             execute_all_jobs(expected_successes: 0, expected_failures: 1)
@@ -79,9 +79,101 @@
         end
       end
     end
+
+
+    context 'last operation' do
+      context 'response for last operation is 200 state failed' do
+        let(:broker_bind_status_code) { 202 }
+        before do
+          stub_request(:get, "#{bind_url}/last_operation").
+            with({ query: { plan_id: plan_id, service_id: offering_id } }).
+            to_return(status: 200, body: '{"state": "failed"}')
+        end
+
+        it 'fails the job and does not perform orphan mitigation' do
+          execute_all_jobs(expected_successes: 0, expected_failures: 1)
+
+          assert_failed_job(binding, job)
+          assert_no_orphan_mitigation_performed(plan_id, offering_id)
+        end
+      end
+
+      context 'response for last operation is 200 with a malformed response' do
+        let(:broker_bind_status_code) { 202 }
+        before do
+          stub_request(:get, "#{bind_url}/last_operation").
+            with({ query: { plan_id: plan_id, service_id: offering_id } }).
+            to_return(status: 200, body: 'this is not json')
+        end
+
+        it 'fails the job and does not perform orphan mitigation' do
+          execute_all_jobs(expected_successes: 1, expected_failures: 0)
+
+          assert_no_orphan_mitigation_performed(plan_id, offering_id)
+        end
+      end
+
+      context 'response for last operation is 410' do
+        let(:broker_bind_status_code) { 202 }
+
+        before do
+          stub_request(:get, "#{bind_url}/last_operation").
+            with({ query: { plan_id: plan_id, service_id: offering_id } }).
+            to_return(status: 410, body: '{}')
+        end
+
+        it 'retries and does not perform orphan mitigation' do
+          execute_all_jobs(expected_successes: 1, expected_failures: 0)
+
+          assert_no_orphan_mitigation_performed(plan_id, offering_id)
+        end
+      end
+
+      context 'response for last operation is 404' do
+        let(:broker_bind_status_code) { 202 }
+        before do
+          stub_request(:get, "#{bind_url}/last_operation").
+            with({ query: { plan_id: plan_id, service_id: offering_id } }).
+            to_return(status: 404, body: '{}')
+        end
+
+        it 'retries and does not perform orphan mitigation' do
+          execute_all_jobs(expected_successes: 1, expected_failures: 0)
+
+          assert_no_orphan_mitigation_performed(plan_id, offering_id)
+        end
+      end
+
+      context 'response for last operation is 400' do
+        let(:broker_bind_status_code) { 202 }
+        before do
+          stub_request(:get, "#{bind_url}/last_operation").
+            with({ query: { plan_id: plan_id, service_id: offering_id } }).
+            to_return(status: 400, body: '{}')
+        end
+
+        it 'retries and does not perform orphan mitigation' do
+          execute_all_jobs(expected_successes: 0, expected_failures: 1)
+
+          assert_no_orphan_mitigation_performed(plan_id, offering_id)
+        end
+      end
+    end
   end
 
   context 'should be performed' do
+    context 'broker returns 200 with bad data' do
+          let(:broker_bind_status_code) { 200 }
+          let(:bind_response_body) { '{ "route_service_url": "bad-url"}' }
+
+          it 'fails the job and performs OM' do
+            execute_all_jobs(expected_successes: 1, expected_failures: 1)
+
+            assert_failed_job(binding, job)
+            assert_orphan_mitigation_performed(plan_id, offering_id)
+          end
+    end
+
     context 'broker returns a 2xx code' do
       [201, 202].each do |code|
         context "response is #{code} with malformed response" do
@@ -98,7 +190,7 @@
       end
 
       [203, 204, 205, 206, 206, 208, 226].each do |code|
-        context "response is #{code}" do
+        context "broker response is #{code}" do
           let(:broker_bind_status_code) { code }
           let(:bind_response_body) { '{}' }
 
@@ -110,6 +202,29 @@
       end
     end
 
+    context 'broker returns a 410 code' do
+        let(:broker_bind_status_code) { 410 }
+
+        it 'does orphan mitigation and fails the job' do
+          execute_all_jobs(expected_successes: 1, expected_failures: 1)
+
+          assert_failed_job(binding, job)
+          assert_orphan_mitigation_performed(plan_id, offering_id)
+        end
+    end
+
+    context 'broker response is 422 with unknown reason' do
+      let(:broker_bind_status_code) { 422 }
+      let(:bind_response_body) { '{ "error": "some random unprocessable entity", "description": "some description" }' }
+
+      it 'fails the job and performs orphan mitigation' do
+        execute_all_jobs(expected_successes: 1, expected_failures: 1)
+
+        assert_failed_job(binding, job)
+        assert_orphan_mitigation_performed(plan_id, offering_id)
+      end
+    end
+
     context 'broker returns a 5xx code' do
       Array(500..511).each do |code|
         context "response is #{code}" do