Display app env variables from app object, not process / revision

* So that apps can show env var changes even if not yet restarted

[finishes #171751119]

Authored-by: Renee Chu <rchu@pivotal.io>

Author: reneighbor

app/controllers/runtime/app_summaries_controller.rb

@@ -25,6 +25,8 @@ def summary(guid)
         'available_domains' => (process.space.organization.private_domains + SharedDomain.all).map(&:as_summary_json)
       }.merge(process.to_hash)
 
+      app_info['environment_json'] = process.app.environment_variables
+
       MultiJson.dump(app_info)
     end
 

spec/unit/controllers/runtime/app_summaries_controller_spec.rb

@@ -9,9 +9,10 @@ module VCAP::CloudController
       @shared_domain = SharedDomain.make
       @shared_domain.save
 
-      @space    = Space.make
-      @route1   = Route.make(space: @space)
-      @route2   = Route.make(space: @space)
+      @space = Space.make
+      @environment_json = { 'HELLO' => 'WORLD' }
+      @route1 = Route.make(space: @space)
+      @route2 = Route.make(space: @space)
       @services = []
 
       @process = ProcessModelFactory.make(
@@ -20,6 +21,7 @@ module VCAP::CloudController
         instances:  1,
         memory:     @free_mem_size,
         state:      'STARTED',
+        environment_json: @environment_json
       )
 
       @num_services.times do
@@ -56,6 +58,8 @@ module VCAP::CloudController
         it 'should contain the basic app attributes' do
           expect(last_response.status).to eq(200)
           expect(decoded_response['guid']).to eq(@process.app.guid)
+          expect(decoded_response['environment_json']).to eq({ 'HELLO' => 'WORLD' })
+
           parse(MultiJson.dump(@process.to_hash)).each do |k, v|
             expect(v).to eql(decoded_response[k.to_s]), "value of field #{k} expected to eql #{v}"
           end