v3(services): binding request spec shared examples (cloudfoundry#1951)

Some shared examples that are used for all list request specs were
added - although the implementation already existed as a result of
using common code.

[#171359160](https://www.pivotaltracker.com/story/show/171359160)

Author: blgm

spec/request/service_credential_bindings_spec.rb

@@ -13,6 +13,33 @@
   end
 
   describe 'GET /v3/service_credential_bindings' do
+    it_behaves_like 'request_spec_shared_examples.rb list query endpoint' do
+      let(:request) { 'v3/service_credential_bindings' }
+      let(:message) { VCAP::CloudController::ServiceCredentialBindingListMessage }
+      let(:user_header) { headers_for(user) }
+      let(:params) do
+        {
+          names: 'foo bar',
+          include: 'app,service_instance',
+          service_instance_names: %w(foo bar),
+          service_instance_guids: %w(foo bar),
+          service_plan_names: %w(foo bar),
+          service_plan_guids: %w(foo bar),
+          service_offering_names: %w(foo bar),
+          service_offering_guids: %w(foo bar),
+          app_names: %w(foo bar),
+          app_guids: %w(foo bar),
+          type: 'app',
+          per_page: '10',
+          page: 2,
+          order_by: 'updated_at',
+          guids: 'foo,bar',
+          created_ats: "#{Time.now.utc.iso8601},#{Time.now.utc.iso8601}",
+          updated_ats: { gt: Time.now.utc.iso8601 },
+        }
+      end
+    end
+
     describe 'order_by' do
       it_behaves_like 'list endpoint order_by name', '/v3/service_credential_bindings' do
         let(:resource_klass) { VCAP::CloudController::ServiceBinding }

spec/request/service_route_bindings_spec.rb

@@ -3,6 +3,55 @@
 
 RSpec.describe 'v3 service route bindings' do
   describe 'GET /v3/service_route_bindings' do
+    # Because route bindings don't have names, we can't use the 'paginated response' shared example
+    describe 'behaving like a paginated resource' do
+      let!(:resources) { Array.new(2) { VCAP::CloudController::RouteBinding.make } }
+
+      it 'returns pagination information' do
+        get '/v3/service_route_bindings?per_page=1', nil, admin_headers
+
+        expect(last_response).to have_status_code(200)
+        expect_route_bindings([resources[0]])
+
+        expect(parsed_response['pagination']['total_results']).to eq(resources.length)
+        expect(parsed_response['pagination']['total_pages']).to eq(resources.length)
+        expect(parsed_response['pagination']['first']['href']).to include('/v3/service_route_bindings?page=1&per_page=1')
+        expect(parsed_response['pagination']['next']['href']).to include('/v3/service_route_bindings?page=2&per_page=1')
+        expect(parsed_response['pagination']['last']['href']).to include("/v3/service_route_bindings?page=#{resources.length}&per_page=1")
+      end
+
+      it 'keeps filtering information in links' do
+        resources_guids = resources.map(&:guid)
+        get "/v3/service_route_bindings?per_page=1&guids=#{resources_guids.join(',')}", nil, admin_headers
+
+        expect(last_response).to have_status_code(200)
+        expect_route_bindings([resources[0]])
+
+        expect(parsed_response['pagination']['next']['href']).to include("guids=#{resources_guids.join('%2C')}")
+      end
+    end
+
+    it_behaves_like 'request_spec_shared_examples.rb list query endpoint' do
+      let(:request) { 'v3/service_route_bindings' }
+      let(:message) { VCAP::CloudController::ServiceRouteBindingsListMessage }
+      let(:user_header) { headers_for(user) }
+      let(:params) do
+        {
+          include: 'route,service_instance',
+          route_guids: %w(foo bar),
+          service_instance_names: %w(foo bar),
+          service_instance_guids: %w(foo bar),
+          per_page: '10',
+          page: 2,
+          order_by: 'updated_at',
+          label_selector: 'foo==bar',
+          guids: 'foo,bar',
+          created_ats: "#{Time.now.utc.iso8601},#{Time.now.utc.iso8601}",
+          updated_ats: { gt: Time.now.utc.iso8601 },
+        }
+      end
+    end
+
     describe 'no bindings to list' do
       let(:api_call) { ->(user_headers) { get '/v3/service_route_bindings', nil, user_headers } }
       let(:expected_codes_and_responses) do
@@ -183,6 +232,12 @@
         expect(last_response).to have_status_code(400)
       end
     end
+
+    describe 'order_by' do
+      it_behaves_like 'list endpoint order_by timestamps', '/v3/service_route_bindings' do
+        let(:resource_klass) { VCAP::CloudController::RouteBinding }
+      end
+    end
   end
 
   describe 'GET /v3/service_route_bindings/:guid' do