Update rubocop to 0.82.0

Authored-by: Greg Cobb <gcobb@pivotal.io>

Author: Gerg

.rubocop.yml

@@ -313,3 +313,9 @@ Lint/RaiseException:
 Lint/StructNewOverride:
   Enabled: true
 
+Layout/SpaceAroundMethodCallOperator:
+  Enabled: true
+
+Style/ExponentialNotation:
+  Enabled: true
+

Gemfile

@@ -88,7 +88,7 @@ group :test do
   gem 'rspec-rails', '~> 3.9.1'
   gem 'rspec-wait'
   gem 'rspec_api_documentation', '>= 6.1.0'
-  gem 'rubocop', '~> 0.81.0'
+  gem 'rubocop', '~> 0.82.0'
   gem 'timecop'
   gem 'webmock', '> 2.3.1'
 end

Gemfile.lock

@@ -394,7 +394,7 @@ GEM
       activesupport (>= 3.0.0)
       mustache (~> 1.0, >= 0.99.4)
       rspec (~> 3.0)
-    rubocop (0.81.0)
+    rubocop (0.82.0)
       jaro_winkler (~> 1.5.1)
       parallel (~> 1.10)
       parser (>= 2.7.0.1)
@@ -563,7 +563,7 @@ DEPENDENCIES
   rspec-rails (~> 3.9.1)
   rspec-wait
   rspec_api_documentation (>= 6.1.0)
-  rubocop (~> 0.81.0)
+  rubocop (~> 0.82.0)
   ruby-debug-ide (>= 0.7.0.beta4)
   rubyzip (>= 1.3.0)
   scientist (~> 1.1.0)

lib/sequel_plugins/vcap_validations.rb

@@ -5,7 +5,7 @@ module InstanceMethods
     # @param [Symbol] The attribute to validate
     def validates_url(attr, opts={})
       if send(attr)
-        validates_format(URI.regexp(%w(http https)), attr, message: opts.fetch(:message, :url))
+        validates_format(URI::DEFAULT_PARSER.make_regexp(%w(http https)), attr, message: opts.fetch(:message, :url))
       end
     end
 

lib/services/service_brokers/v2/response_parser.rb

@@ -659,7 +659,7 @@ def validate(method:, uri:, code:, response:)
             parameters = parsed_response['parameters']
 
             if parameters && !parameters.is_a?(Hash)
-              raise Errors::ServiceBrokerResponseMalformed. new(uri, method, response,
+              raise Errors::ServiceBrokerResponseMalformed.new(uri, method, response,
                 'The service broker response contained a parameters field that was not a JSON object.')
             end
 

lib/vcap/rest_api/message.rb

@@ -28,7 +28,7 @@ def self.schema_doc(schema)
         schema.deparse
       end
 
-      URL = readable_regexp(URI.regexp(%w(http https)),
+      URL = readable_regexp(URI::DEFAULT_PARSER.make_regexp(%w(http https)),
                                   'String /URL_REGEX/',
                                   'must be a valid URL')
       HTTPS_URL = readable_regexp(URI::DEFAULT_PARSER.make_regexp('https'),
@@ -37,7 +37,7 @@ def self.schema_doc(schema)
       EMAIL = readable_regexp(RFC822::EMAIL_REGEXP_WHOLE,
                                   'String /EMAIL_REGEX/',
                                   'must be a valid email')
-      GIT_URL = readable_regexp(URI.regexp(%w(http https git)),
+      GIT_URL = readable_regexp(URI::DEFAULT_PARSER.make_regexp(%w(http https git)),
                                   'String /GIT_URL_REGEX/',
                                   'must be a valid git URL')
 

lib/vcap/services/api/messages.rb

@@ -18,12 +18,12 @@ class EmptyRequest < JsonMessage
       #
       class ServiceOfferingRequest < JsonMessage
         required :label,        SERVICE_LABEL_REGEX
-        required :url,          URI.regexp(%w(http https))
+        required :url,          URI::DEFAULT_PARSER.make_regexp(%w(http https))
         required :supported_versions, [String]
         required :version_aliases, Hash
 
         optional :description,  String
-        optional :info_url,     URI.regexp(%w(http https))
+        optional :info_url,     URI::DEFAULT_PARSER.make_regexp(%w(http https))
         optional :tags,         [String]
         optional :plan_details do
           [
@@ -197,7 +197,7 @@ class Job < JsonMessage
       end
 
       class SerializedURL < JsonMessage
-        required :url, URI.regexp(%w(http https))
+        required :url, URI::DEFAULT_PARSER.make_regexp(%w(http https))
       end
 
       class SerializedData < JsonMessage

spec/request/app_manifests_spec.rb

@@ -588,7 +588,7 @@
     let!(:app_annotation) { VCAP::CloudController::AppAnnotationModel.make(resource_guid: app_model.guid, key: 'style', value: 'mashed') }
 
     let!(:sidecar1) { VCAP::CloudController::SidecarModel.make(name: 'authenticator', command: './authenticator', app: app_model) }
-    let!(:sidecar2) { VCAP::CloudController:: SidecarModel.make(name: 'my_sidecar', command: 'rackup', app: app_model) }
+    let!(:sidecar2) { VCAP::CloudController::SidecarModel.make(name: 'my_sidecar', command: 'rackup', app: app_model) }
 
     let!(:sidecar_process_type1) { VCAP::CloudController::SidecarProcessTypeModel.make(type: 'worker', sidecar: sidecar1, app_guid: app_model.guid) }
     let!(:sidecar_process_type2) { VCAP::CloudController::SidecarProcessTypeModel.make(type: 'web', sidecar: sidecar1, app_guid: app_model.guid) }

spec/unit/lib/cloud_controller/diego/task_recipe_builder_spec.rb

@@ -269,7 +269,7 @@ module Diego
 
           it 'sets the network information' do
             result = task_recipe_builder.build_staging_task(config, staging_details)
-            expect(result.network). to eq(expected_network)
+            expect(result.network).to eq(expected_network)
           end
 
           it 'sets the egress rules' do
@@ -472,7 +472,7 @@ module Diego
             expect(result.legacy_download_user).to eq('vcap')
             expect(result.root_fs).to eq('preloaded:potato-stack')
             expect(result.completion_callback_url).to eq(expected_callback_url)
-            expect(result.network). to eq(expected_network)
+            expect(result.network).to eq(expected_network)
             expect(result.privileged).to be(false)
             expect(result.volume_mounts).to eq([])
             expect(result.egress_rules).to eq([

spec/unit/messages/packages_list_message_spec.rb

@@ -163,7 +163,7 @@ module VCAP::CloudController
         it 'is not valid if guids is not an array' do
           message = PackagesListMessage.from_params guids: 'tricked you, not an array'
           expect(message).to be_invalid
-          expect(message.errors[:guids]). to include('must be an array')
+          expect(message.errors[:guids]).to include('must be an array')
         end
 
         it 'allows guids to be nil' do