v3(services) Return validation od quotas for service key creation

[#174146711](https://www.pivotaltracker.com/story/show/174146711)

Author: FelisiaM

app/actions/mixins/service_credential_binding_validation_create.rb

@@ -0,0 +1,30 @@
+module VCAP::CloudController
+  module ServiceCredentialBindingCreateMixin
+    private
+
+    def validate_service_key_quotas!(errors, validation_error_handler)
+      quota_errors = errors.on(:quota).to_a
+
+      if quota_errors.include?(:service_keys_space_quota_exceeded)
+        validation_error_handler.error!("You have exceeded your space's limit for service binding of type key.")
+      elsif quota_errors.include?(:service_keys_quota_exceeded)
+        validation_error_handler.error!("You have exceeded your organization's limit for service binding of type key.")
+      end
+    end
+
+    def key_validation_error!(
+      exception,
+      name:,
+      validation_error_handler:
+    )
+      errors = exception.errors
+      validate_service_key_quotas!(errors, validation_error_handler)
+
+      if errors.on([:name, :service_instance_id])&.include?(:unique)
+        validation_error_handler.error!("The binding name is invalid. Key binding names must be unique. The service instance already has a key binding with name '#{name}'.")
+      end
+
+      validation_error_handler.error!(exception.message)
+    end
+  end
+end

app/actions/service_credential_binding_key_create.rb

@@ -1,6 +1,10 @@
+require 'actions/mixins/service_credential_binding_validation_create'
+
 module VCAP::CloudController
   module V3
     class ServiceCredentialBindingKeyCreate
+      include ServiceCredentialBindingCreateMixin
+
       class UnprocessableCreate < StandardError
       end
 
@@ -17,8 +21,11 @@ def precursor(service_instance, name)
           ServiceKey.create(**binding_details)
         end
       rescue Sequel::ValidationFailed => e
-        key_already_exists!(name) if e.message == 'name and service_instance_id unique'
-        raise UnprocessableCreate.new(e.message)
+        key_validation_error!(
+          e,
+          name: name,
+          validation_error_handler: ValidationErrorHandler.new
+        )
       end
 
       private
@@ -56,6 +63,12 @@ def service_not_available!
       def volume_mount_not_enabled!
         raise UnprocessableCreate.new('Support for volume mount services is disabled.')
       end
+
+      class ValidationErrorHandler
+        def error!(message)
+          raise UnprocessableCreate.new(message)
+        end
+      end
     end
   end
 end

spec/request/service_credential_bindings_spec.rb

@@ -1659,6 +1659,53 @@ def check_filtered_bindings(*bindings)
             }))
           end
         end
+
+        context 'quotas restrictions' do
+          describe 'space quotas' do
+            context 'when the total service key quota has been reached' do
+              before do
+                quota = VCAP::CloudController::SpaceQuotaDefinition.make(total_service_keys: 1, organization: org)
+                quota.add_space(space)
+
+                VCAP::CloudController::ServiceKey.make(service_instance: service_instance)
+              end
+
+              it 'returns an error' do
+                api_call.call(space_dev_headers)
+                expect(last_response).to have_status_code(422)
+                expect(parsed_response['errors']).to include(
+                  include({
+                    'detail' => "You have exceeded your space's limit for service binding of type key.",
+                    'title' => 'CF-UnprocessableEntity',
+                    'code' => 10008,
+                  })
+                )
+              end
+            end
+          end
+
+          describe 'organization quotas' do
+            context 'when the total service key quota has been reached' do
+              before do
+                quota = VCAP::CloudController::QuotaDefinition.make(total_service_keys: 1)
+                quota.add_organization(org)
+                VCAP::CloudController::ServiceKey.make(service_instance: service_instance)
+              end
+
+              it 'returns an error' do
+                api_call.call(space_dev_headers)
+                expect(last_response).to have_status_code(422)
+                expect(parsed_response['errors']).to include(
+                  include({
+                    'detail' => "You have exceeded your organization's limit for service binding of type key.",
+                    'title' => 'CF-UnprocessableEntity',
+                    'code' => 10008,
+                  })
+                )
+              end
+            end
+          end
+        end
       end
 
       it 'should return 501' do

spec/unit/actions/service_credential_binding_key_create_spec.rb

@@ -7,7 +7,8 @@ module V3
     RSpec.describe ServiceCredentialBindingKeyCreate do
       subject(:action) { described_class.new }
 
-      let(:space) { Space.make }
+      let(:org) { Organization.make }
+      let(:space) { Space.make(organization: org) }
       let(:binding_details) {}
       let(:name) { 'test-key' }
 
@@ -85,10 +86,55 @@ module V3
             end
           end
 
+          context 'when the name is taken' do
+            let(:existing_service_key) { ServiceKey.make(service_instance: service_instance) }
+
+            it 'raises an error' do
+              expect { action.precursor(service_instance, existing_service_key.name) }.to raise_error(
+                ServiceCredentialBindingKeyCreate::UnprocessableCreate,
+                "The binding name is invalid. Key binding names must be unique. The service instance already has a key binding with name '#{existing_service_key.name}'."
+              )
+            end
+          end
+
           context 'when successful' do
             it_behaves_like 'the credential binding precursor'
           end
         end
+
+        context 'quotas' do
+          let(:service_instance) { ManagedServiceInstance.make(space: space) }
+
+          context 'when service key limit has been reached for the space' do
+            before do
+              quota = SpaceQuotaDefinition.make(total_service_keys: 1, organization: org)
+              quota.add_space(space)
+              ServiceKey.make(service_instance: service_instance)
+            end
+
+            it 'raises an error' do
+              expect { action.precursor(service_instance, name) }.to raise_error(
+                ServiceCredentialBindingKeyCreate::UnprocessableCreate,
+                "You have exceeded your space's limit for service binding of type key."
+              )
+            end
+          end
+
+          context 'when service key limit has been reached for the org' do
+            before do
+              quotas = QuotaDefinition.make(total_service_keys: 1)
+              quotas.add_organization(org)
+              ServiceKey.make(service_instance: service_instance)
+            end
+
+            it 'raises an error' do
+              expect { action.precursor(service_instance, name) }.to raise_error(
+                ServiceCredentialBindingKeyCreate::UnprocessableCreate,
+                "You have exceeded your organization's limit for service binding of type key."
+              )
+            end
+          end
+        end
       end
     end
   end