v3(services): unbind service key

[#175557761](https://www.pivotaltracker.com/story/show/175557761)

Author: pivotal-marcela-campo

app/actions/service_credential_binding_delete.rb

@@ -1,11 +1,18 @@
 require 'actions/v3/service_binding_delete'
+require 'repositories/service_generic_binding_event_repository'
 
 module VCAP::CloudController
   module V3
     class ServiceCredentialBindingDelete < V3::ServiceBindingDelete
-      def initialize(user_audit_info)
+      EVENT_REPOSITORY_TYPES = {
+        key: Repositories::ServiceGenericBindingEventRepository::SERVICE_KEY_CREDENTIAL_BINDING,
+        credential: Repositories::ServiceGenericBindingEventRepository::SERVICE_APP_CREDENTIAL_BINDING
+      }.freeze
+
+      def initialize(type, user_audit_info)
         super()
         @user_audit_info = user_audit_info
+        @event_repository_type = EVENT_REPOSITORY_TYPES[type]
       end
 
       private
@@ -21,8 +28,7 @@ def perform_start_delete_actions(binding)
       end
 
       def event_repository
-        @event_repository ||= Repositories::ServiceGenericBindingEventRepository.new(
-          Repositories::ServiceGenericBindingEventRepository::SERVICE_APP_CREDENTIAL_BINDING)
+        @event_repository ||= Repositories::ServiceGenericBindingEventRepository.new(@event_repository_type)
       end
     end
   end

app/controllers/v3/service_credential_bindings_controller.rb

@@ -66,19 +66,16 @@ def destroy
     not_found! unless service_credential_binding.present?
     unauthorized! unless can_write_to_space?(binding_space)
 
-    if service_credential_binding.is_a?(ServiceKey)
-      head :not_implemented
-      return
-    end
+    type = service_credential_binding.is_a?(ServiceKey) ? :key : :credential
 
     operation_in_progress! if service_credential_binding.service_instance.operation_in_progress?
 
     case service_credential_binding.service_instance
     when ManagedServiceInstance
-      pollable_job_guid = enqueue_unbind_job(service_credential_binding.guid)
+      pollable_job_guid = enqueue_unbind_job(type, service_credential_binding.guid)
       head :accepted, 'Location' => url_builder.build_url(path: "/v3/jobs/#{pollable_job_guid}")
     when UserProvidedServiceInstance
-      action = V3::ServiceCredentialBindingDelete.new(user_audit_info)
+      action = V3::ServiceCredentialBindingDelete.new(type, user_audit_info)
       action.delete(service_credential_binding)
       head :no_content
     end
@@ -179,9 +176,9 @@ def enqueue_bind_job(type, binding_guid, message)
     pollable_job.guid
   end
 
-  def enqueue_unbind_job(binding_guid)
+  def enqueue_unbind_job(type, binding_guid)
     bind_job = VCAP::CloudController::V3::DeleteBindingJob.new(
-      :credential,
+      type,
       binding_guid,
       user_audit_info: user_audit_info,
     )

app/jobs/v3/delete_service_binding_job_factory.rb

@@ -1,5 +1,6 @@
 require 'jobs/v3/delete_service_route_binding_job_actor'
 require 'jobs/v3/delete_service_credential_binding_job_actor'
+require 'jobs/v3/delete_service_key_binding_job_actor'
 require 'actions/service_route_binding_delete'
 require 'actions/service_credential_binding_delete'
 
@@ -15,6 +16,8 @@ def self.for(type)
           DeleteServiceRouteBindingJobActor.new
         when :credential
           DeleteServiceCredentialBindingJobActor.new
+        when :key
+          DeleteServiceKeyBindingJobActor.new
         else
           raise InvalidType
         end
@@ -24,8 +27,8 @@ def self.action(type, user_audit_info)
         case type
         when :route
           V3::ServiceRouteBindingDelete.new(user_audit_info)
-        when :credential
-          V3::ServiceCredentialBindingDelete.new(user_audit_info)
+        when :credential, :key
+          V3::ServiceCredentialBindingDelete.new(type, user_audit_info)
         else
           raise InvalidType
         end

app/jobs/v3/delete_service_credential_binding_job_actor.rb

@@ -1,7 +1,3 @@
-require 'jobs/reoccurring_job'
-require 'actions/service_credential_binding_app_create'
-require 'cloud_controller/errors/api_error'
-
 module VCAP::CloudController
   module V3
     class DeleteServiceCredentialBindingJobActor

app/jobs/v3/delete_service_key_binding_job_actor.rb

@@ -0,0 +1,17 @@
+module VCAP::CloudController
+  module V3
+    class DeleteServiceKeyBindingJobActor
+      def display_name
+        'service_keys.delete'
+      end
+
+      def resource_type
+        'service_credential_binding'
+      end
+
+      def get_resource(resource_id)
+        ServiceKey.first(guid: resource_id)
+      end
+    end
+  end
+end