v3(services): namespace v3 si delete action

to avoid clashing with the v2 implementation

[#171726582](https://www.pivotaltracker.com/story/show/171726582)

Author: Derik Evangelista

app/actions/service_instance_delete.rb

@@ -0,0 +1,42 @@
+module VCAP::CloudController
+  module V3
+    class ServiceInstanceDelete
+      class AssociationNotEmptyError < StandardError; end
+      class InstanceSharedError < StandardError; end
+      class NotImplementedError < StandardError; end
+
+      def initialize(event_repo)
+        @service_event_repository = event_repo
+      end
+
+      def delete(service_instance)
+        association_not_empty! if service_instance.has_bindings? || service_instance.has_keys? || service_instance.has_routes?
+
+        cannot_delete_shared_instances! if service_instance.shared?
+
+        case service_instance
+        when ManagedServiceInstance
+          raise NotImplementedError
+        end
+
+        service_instance.db.transaction do
+          service_instance.lock!
+          service_instance.destroy
+          service_event_repository.record_user_provided_service_instance_event(:delete, service_instance, {})
+        end
+      end
+
+      private
+
+      def association_not_empty!
+        raise AssociationNotEmptyError
+      end
+
+      def cannot_delete_shared_instances!
+        raise InstanceSharedError
+      end
+
+      attr_reader :service_event_repository
+    end
+  end
+end

app/actions/v3/service_instance_delete.rb

@@ -15,7 +15,7 @@
 require 'actions/service_instance_update_managed'
 require 'actions/service_instance_update_user_provided'
 require 'actions/service_instance_create_user_provided'
-require 'actions/service_instance_delete'
+require 'actions/v3/service_instance_delete'
 require 'actions/service_instance_create_managed'
 require 'fetchers/service_instance_list_fetcher'
 require 'decorators/field_service_instance_space_decorator'
@@ -110,14 +110,14 @@ def destroy
     unauthorized! unless can_write_space?(service_instance.space)
 
     service_event_repository = VCAP::CloudController::Repositories::ServiceEventRepository::WithUserActor.new(user_audit_info)
-    ServiceInstanceDelete.new(service_event_repository).delete(service_instance)
+    V3::ServiceInstanceDelete.new(service_event_repository).delete(service_instance)
 
     head :no_content
-  rescue ServiceInstanceDelete::AssociationNotEmptyError
+  rescue V3::ServiceInstanceDelete::AssociationNotEmptyError
     associations_not_empty!
-  rescue ServiceInstanceDelete::InstanceSharedError
+  rescue V3::ServiceInstanceDelete::InstanceSharedError
     cannot_delete_shared_instances!(service_instance.name)
-  rescue ServiceInstanceDelete::NotImplementedError
+  rescue V3::ServiceInstanceDelete::NotImplementedError
     head :not_implemented
   end
 

app/controllers/v3/service_instances_controller.rb

@@ -0,0 +1,116 @@
+require 'spec_helper'
+require 'actions/v3/service_instance_delete'
+
+module VCAP
+  module CloudController
+    RSpec.describe V3::ServiceInstanceDelete do
+      describe '#delete' do
+        subject(:action) { described_class.new(event_repository) }
+        let(:event_repository) do
+          dbl = double(Repositories::ServiceEventRepository::WithUserActor)
+          allow(dbl).to receive(:record_user_provided_service_instance_event)
+          dbl
+        end
+
+        let!(:service_instance) do
+          si = VCAP::CloudController::UserProvidedServiceInstance.make(
+            name: 'foo',
+            credentials: {
+              foo: 'bar',
+              baz: 'qux'
+            },
+            syslog_drain_url: 'https://foo.com',
+            route_service_url: 'https://bar.com',
+            tags: %w(accounting mongodb)
+          )
+          si.label_ids = [
+            VCAP::CloudController::ServiceInstanceLabelModel.make(key_prefix: 'pre.fix', key_name: 'to_delete', value: 'value'),
+            VCAP::CloudController::ServiceInstanceLabelModel.make(key_prefix: 'pre.fix', key_name: 'tail', value: 'fluffy')
+          ]
+          si.annotation_ids = [
+            VCAP::CloudController::ServiceInstanceAnnotationModel.make(key_prefix: 'pre.fix', key_name: 'to_delete', value: 'value').id,
+            VCAP::CloudController::ServiceInstanceAnnotationModel.make(key_prefix: 'pre.fix', key_name: 'fox', value: 'bushy').id
+          ]
+          si
+        end
+
+        it 'deletes an user provided service instance from the database' do
+          subject.delete(service_instance)
+
+          expect {
+            service_instance.reload
+          }.to raise_error(Sequel::Error, 'Record not found')
+          expect(VCAP::CloudController::ServiceInstanceLabelModel.where(service_instance: service_instance)).to be_empty
+          expect(VCAP::CloudController::ServiceInstanceAnnotationModel.where(service_instance: service_instance)).to be_empty
+        end
+
+        it 'fails to delete managed service instances' do
+          instance = VCAP::CloudController::ManagedServiceInstance.make
+          expect { subject.delete(instance) }.to raise_error(V3::ServiceInstanceDelete::NotImplementedError)
+          expect { instance.reload }.not_to raise_error
+        end
+
+        it 'creates an audit event' do
+          subject.delete(service_instance)
+
+          expect(event_repository).
+            to have_received(:record_user_provided_service_instance_event).
+            with(:delete, instance_of(UserProvidedServiceInstance), {})
+        end
+
+        describe 'invalid pre-conditions' do
+          context 'when there are associated service bindings' do
+            before do
+              VCAP::CloudController::ServiceBinding.make(service_instance: service_instance)
+            end
+
+            it 'does not delete the service instance' do
+              expect { subject.delete(service_instance) }.to raise_error(V3::ServiceInstanceDelete::AssociationNotEmptyError)
+              expect { service_instance.reload }.not_to raise_error
+            end
+          end
+
+          context 'when there are associated service keys' do
+            before do
+              VCAP::CloudController::ServiceKey.make(service_instance: service_instance)
+            end
+
+            it 'does not delete the service instance' do
+              expect { subject.delete(service_instance) }.to raise_error(V3::ServiceInstanceDelete::AssociationNotEmptyError)
+              expect { service_instance.reload }.not_to raise_error
+            end
+          end
+
+          context 'when there are associated route bindings' do
+            before do
+              VCAP::CloudController::RouteBinding.make(
+                service_instance: service_instance,
+                route: VCAP::CloudController::Route.make(space: service_instance.space)
+              )
+            end
+
+            it 'does not delete the service instance' do
+              expect { subject.delete(service_instance) }.to raise_error(V3::ServiceInstanceDelete::AssociationNotEmptyError)
+              expect { service_instance.reload }.not_to raise_error
+            end
+          end
+
+          context 'when the service instance is shared' do
+            let(:space) { VCAP::CloudController::Space.make }
+            let(:other_space) { VCAP::CloudController::Space.make }
+            let!(:service_instance) {
+              si = VCAP::CloudController::ServiceInstance.make(space: space)
+              si.shared_space_ids = [other_space.id]
+              si
+            }
+
+            it 'does not delete the service instance' do
+              expect { subject.delete(service_instance) }.to raise_error(V3::ServiceInstanceDelete::InstanceSharedError)
+              expect { service_instance.reload }.not_to raise_error
+            end
+          end
+        end
+      end
+    end
+  end
+end