v3(services): Prevent route binding while other operations are in progress

[#174540070](https://www.pivotaltracker.com/story/show/174540070)

Author: pivotal-marcela-campo

app/actions/service_route_binding_create.rb

@@ -6,12 +6,7 @@ def initialize(service_event_repository)
       end
 
       def precursor(service_instance, route)
-        not_supported! unless service_instance.route_service?
-        not_bindable! unless service_instance.bindable?
-        route_is_internal! if route.try(:internal?)
-        space_mismatch! unless route.space == service_instance.space
-        already_exists! if route.service_instance == service_instance
-        already_bound! if route.service_instance
+        validate!(service_instance, route)
 
         RouteBinding.new.save_with_new_operation(
           {
@@ -98,6 +93,16 @@ class BindingNotRetrievable < StandardError; end
 
       private
 
+      def validate!(service_instance, route)
+        not_supported! unless service_instance.route_service?
+        not_bindable! unless service_instance.bindable?
+        route_is_internal! if route.try(:internal?)
+        space_mismatch! unless route.space == service_instance.space
+        already_exists! if route.service_instance == service_instance
+        already_bound! if route.service_instance
+        operation_in_progress! if service_instance.operation_in_progress?
+      end
+
       attr_reader :service_event_repository
 
       def fetch_last_operation(client, binding)
@@ -154,6 +159,10 @@ def bindings_retrievable?(binding)
         binding.service_instance.service.bindings_retrievable
       end
 
+      def operation_in_progress!
+        raise UnprocessableCreate.new('There is an operation in progress for the service instance')
+      end
+
       def route_is_internal!
         raise UnprocessableCreate.new('Route services cannot be bound to internal routes')
       end

spec/request/service_route_bindings_spec.rb

@@ -504,6 +504,21 @@
           expect(VCAP::CloudController::RouteBinding.all).to be_empty
         end
       end
+
+      context 'there is an operation in progress for the service instance' do
+        it 'responds with 422' do
+          service_instance.save_with_new_operation({}, { type: 'guacamole', state: 'in progress' })
+
+          post '/v3/service_route_bindings', request.to_json, space_dev_headers
+
+          expect(last_response).to have_status_code(422)
+          expect(parsed_response['errors']).to include(include({
+            'detail' => include('There is an operation in progress for the service instance'),
+            'title' => 'CF-UnprocessableEntity',
+            'code' => 10008,
+          }))
+        end
+      end
     end
 
     context 'user-provided service instance' do

spec/unit/actions/service_route_binding_create_spec.rb

@@ -120,6 +120,19 @@ module V3
               )
             end
           end
+
+          context 'when there is an operation in progress for the service instance' do
+            it 'raises an error' do
+              service_instance.save_with_new_operation({}, { type: 'tacos', state: 'in progress' })
+
+              expect {
+                action.precursor(service_instance, route)
+              }.to raise_error(
+                ServiceRouteBindingCreate::UnprocessableCreate,
+                'There is an operation in progress for the service instance'
+              )
+            end
+          end
         end
 
         context 'user-provided service instance' do