v3(services): add common filters to service route bindings resource

[#175686797](https://www.pivotaltracker.com/story/show/175686797)

Author: pivotal-marcela-campo

app/controllers/v3/service_route_bindings_controller.rb

@@ -155,11 +155,10 @@ def enqueue_unbind_job(binding_guid)
   end
 
   def fetch_route_bindings(message)
-    fetcher = RouteBindingListFetcher.new
     if permission_queryer.can_read_globally?
-      fetcher.fetch_all(message)
+      RouteBindingListFetcher.fetch_all(message)
     else
-      fetcher.fetch_some(message, space_guids: space_guids)
+      RouteBindingListFetcher.fetch_some(message, space_guids: space_guids)
     end
   end
 

app/fetchers/route_binding_list_fetcher.rb

@@ -1,54 +1,58 @@
 module VCAP
   module CloudController
-    class RouteBindingListFetcher
-      def fetch_all(message)
-        filter(message, all_bindings).
-          select_all(:route_bindings)
-      end
+    class RouteBindingListFetcher < BaseListFetcher
+      class << self
+        def fetch_all(message)
+          filter(message, all_bindings).
+            select_all(:route_bindings)
+        end
 
-      def fetch_some(message, space_guids:)
-        bindings = all_bindings.
-                   join(:spaces, id: Sequel[:service_instances][:space_id]).
-                   where { Sequel[:spaces][:guid] =~ space_guids }
+        def fetch_some(message, space_guids:)
+          bindings = all_bindings.
+                     join(:spaces, id: Sequel[:service_instances][:space_id]).
+                     where { Sequel[:spaces][:guid] =~ space_guids }
 
-        filter(message, bindings).
-          select_all(:route_bindings)
-      end
+          filter(message, bindings).
+            select_all(:route_bindings)
+        end
 
-      private
+        private
 
-      def all_bindings
-        RouteBinding.dataset.
-          join(:service_instances, id: Sequel[:route_bindings][:service_instance_id]).
-          join(:routes, id: Sequel[:route_bindings][:route_id])
-      end
+        def filter(message, bindings)
+          filters = {
+            service_instance_guids: ->(dataset, requested) do
+              dataset.where { Sequel[:service_instances][:guid] =~ requested.service_instance_guids }
+            end,
+            service_instance_names: ->(dataset, requested) do
+              dataset.where { Sequel[:service_instances][:name] =~ requested.service_instance_names }
+            end,
+            route_guids: ->(dataset, requested) do
+              dataset.where { Sequel[:routes][:guid] =~ requested.route_guids }
+            end,
+            label_selector: ->(dataset, requested) do
+              LabelSelectorQueryGenerator.add_selector_queries(
+                label_klass: RouteBindingLabelModel,
+                resource_dataset: dataset,
+                requirements: requested.requirements,
+                resource_klass: RouteBinding
+              )
+            end
+          }
 
-      def filter(message, bindings)
-        FILTERS.
-          select { |filter_name| message.requested?(filter_name) }.
-          values.
-          reduce(bindings) { |dataset, filter| filter.call(dataset, message) }
-      end
+          bindings = filters.
+                     select { |filter_name| message.requested?(filter_name) }.
+                     values.
+                     reduce(bindings) { |dataset, filter| filter.call(dataset, message) }
+
+          super(message, bindings, RouteBinding)
+        end
 
-      FILTERS = {
-        service_instance_guids: ->(dataset, message) do
-          dataset.where { Sequel[:service_instances][:guid] =~ message.service_instance_guids }
-        end,
-        service_instance_names: ->(dataset, message) do
-          dataset.where { Sequel[:service_instances][:name] =~ message.service_instance_names }
-        end,
-        route_guids: ->(dataset, message) do
-          dataset.where { Sequel[:routes][:guid] =~ message.route_guids }
-        end,
-        label_selector: ->(dataset, message) do
-          LabelSelectorQueryGenerator.add_selector_queries(
-            label_klass: RouteBindingLabelModel,
-            resource_dataset: dataset,
-            requirements: message.requirements,
-            resource_klass: RouteBinding
-          )
+        def all_bindings
+          RouteBinding.dataset.
+            join(:service_instances, id: Sequel[:route_bindings][:service_instance_id]).
+            join(:routes, id: Sequel[:route_bindings][:route_id])
         end
-      }.freeze
+      end
     end
   end
 end

docs/v3/source/includes/experimental_resources/service_route_bindings/_list.md.erb

@@ -35,6 +35,9 @@ Name | Type | Description
 **service_instance_guids** | _list of strings_ | Comma-delimited list of service instance guids to filter by
 **service_instance_names** | _list of strings_ | Comma-delimited list of service instance names to filter by
 **label_selector** | _string_ | A query string containing a list of [label selector](#labels-and-selectors) requirements
+**guids** | _list of strings_ | Comma-delimited list of service route binding guids to filter by
+**created_ats** (*experimental*)| _[timestamp](#timestamps)_ | Timestamp to filter by. When filtering on equality, several comma-delimited timestamps may be passed. Also supports filtering with [relational operators](#relational-operators-experimental)
+**updated_ats** (*experimental*)| _[timestamp](#timestamps)_ | Timestamp to filter by. When filtering on equality, several comma-delimited timestamps may be passed. Also supports filtering with [relational operators](#relational-operators-experimental)
 **include** | _list of strings_ | Optionally include a list of unique related resources in the response. Valid values are: `route`, `service_instance`
 **page** | _integer_ | Page to display; valid values are integers >= 1
 **per_page** | _integer_ | Number of results per page; <br>valid values are 1 through 5000

spec/request/service_route_bindings_spec.rb

@@ -189,6 +189,14 @@
 
         expect_route_bindings(filtered_route_bindings)
       end
+
+      it_behaves_like 'list_endpoint_with_common_filters' do
+        let(:resource_klass) { VCAP::CloudController::RouteBinding }
+        let(:api_call) do
+          lambda { |headers, filters| get "/v3/service_route_bindings?#{filters}", nil, headers }
+        end
+        let(:headers) { admin_headers }
+      end
     end
 
     describe 'include' do

spec/unit/fetchers/route_binding_list_fetcher_spec.rb

@@ -4,7 +4,7 @@
 module VCAP
   module CloudController
     RSpec.describe RouteBindingListFetcher do
-      let(:fetcher) { RouteBindingListFetcher.new }
+      let(:fetcher) { described_class }
 
       describe 'fetch_all' do
         let!(:route_bindings) { Array.new(3) { RouteBinding.make } }