Skip to content
This repository was archived by the owner on Jun 2, 2021. It is now read-only.

Commit 6edaa28

Browse files
weymanfbelinda-liu
andcommitted
Bubble up memory errors when pushing/updating sidecars
[#175822881] Co-authored-by: Weyman Fung <weymanf@vmware.com> Co-authored-by: Belinda Liu <bliu@pivotal.io>
1 parent 3fdbf02 commit 6edaa28

2 files changed

Lines changed: 8 additions & 1 deletion

File tree

app/jobs/space_apply_manifest_action_job.rb

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,10 @@ def perform
2323
ManifestRouteUpdate::InvalidRoute,
2424
Route::InvalidOrganizationRelation,
2525
AppApplyManifest::Error,
26-
AppApplyManifest::ServiceBindingError => e
26+
AppApplyManifest::ServiceBindingError,
27+
SidecarCreate::InvalidSidecar,
28+
SidecarUpdate::InvalidSidecar,
29+
ProcessScale::SidecarMemoryLessThanProcessMemory => e
2730

2831
app_name = AppModel.find(guid: app_guid)&.name
2932
error_message = app_name ? "For application '#{app_name}': #{e.message}" : e.message

spec/unit/jobs/space_apply_manifest_action_job_spec.rb

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,11 @@ module Jobs
5454
ProcessScale::InvalidProcess,
5555
ProcessUpdate::InvalidProcess,
5656
Route::InvalidOrganizationRelation,
57+
AppApplyManifest::Error,
5758
AppApplyManifest::ServiceBindingError,
59+
SidecarCreate::InvalidSidecar,
60+
SidecarUpdate::InvalidSidecar,
61+
ProcessScale::SidecarMemoryLessThanProcessMemory,
5862
].each do |klass|
5963
it "wraps a #{klass} in an ApiError" do
6064
allow(apply_manifest_action).to receive(:apply).

0 commit comments

Comments
 (0)