Skip to content
This repository was archived by the owner on Jun 2, 2021. It is now read-only.

Commit 6f222f8

Browse files
sweinstein22selzoc
andcommitted
Extract common revision repository logic to method
[Finishes #174330630] Co-authored-by: Sarah Weinstein <sweinstein@pivotal.io> Co-authored-by: Chris Selzo <cselzo@pivotal.io>
1 parent 3dc80fe commit 6f222f8

1 file changed

Lines changed: 18 additions & 29 deletions

File tree

app/repositories/revision_event_repository.rb

Lines changed: 18 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -3,45 +3,34 @@ module Repositories
33
class RevisionEventRepository
44
def self.record_create(revision, app, user_audit_info)
55
VCAP::AppLogEmitter.emit(revision.app_guid, "Creating revision for app with guid #{app.guid}")
6-
7-
Event.create(
8-
type: 'audit.app.revision.create',
9-
actor: user_audit_info.user_guid,
10-
actor_type: 'user',
11-
actor_name: user_audit_info.user_email,
12-
actor_username: user_audit_info.user_name,
13-
actee: app.guid,
14-
actee_type: 'app',
15-
actee_name: app.name,
16-
timestamp: Sequel::CURRENT_TIMESTAMP,
17-
metadata: {
18-
revision_guid: revision.guid,
19-
revision_version: revision.version
20-
},
21-
space_guid: app.space_guid,
22-
organization_guid: app.space.organization_guid,
23-
)
6+
create_revision_event('audit.app.revision.create', app, revision, user_audit_info)
247
end
258

269
def self.record_show_environment_variables(revision, app, user_audit_info)
10+
create_revision_event('audit.app.revision.environment_variables.show', app, revision, user_audit_info)
11+
end
12+
13+
def self.create_revision_event(type, app, revision, user_audit_info)
2714
Event.create(
28-
type: 'audit.app.revision.environment_variables.show',
29-
actor: user_audit_info.user_guid,
30-
actor_type: 'user',
31-
actor_name: user_audit_info.user_email,
32-
actor_username: user_audit_info.user_name,
33-
actee: app.guid,
34-
actee_type: 'app',
35-
actee_name: app.name,
36-
timestamp: Sequel::CURRENT_TIMESTAMP,
37-
metadata: {
15+
type: type,
16+
actor: user_audit_info.user_guid,
17+
actor_type: 'user',
18+
actor_name: user_audit_info.user_email,
19+
actor_username: user_audit_info.user_name,
20+
actee: app.guid,
21+
actee_type: 'app',
22+
actee_name: app.name,
23+
timestamp: Sequel::CURRENT_TIMESTAMP,
24+
metadata: {
3825
revision_guid: revision.guid,
3926
revision_version: revision.version
4027
},
41-
space_guid: app.space_guid,
28+
space_guid: app.space_guid,
4229
organization_guid: app.space.organization_guid,
4330
)
4431
end
32+
33+
private_class_method :create_revision_event
4534
end
4635
end
4736
end

0 commit comments

Comments
 (0)