V3 build update action updates droplet process types

- removed what we thought was an unnecessary UPDATE call in a DB
transaction, hopefully that doesn't bite us

[#171713645]

Co-authored-by: Piyali Banerjee <pbanerjee@pivotal.io>
Co-authored-by: Jaskanwal Pawar <jpawar@pivotal.io>

Author: 2 people

app/actions/build_update.rb

@@ -17,9 +17,9 @@ def update(build, message)
         elsif message.state == VCAP::CloudController::BuildModel::STAGED_STATE
           droplet = VCAP::CloudController::DropletCreate.new.create_docker_droplet(build)
           droplet.lock!
-          droplet.update(docker_receipt_image: message.lifecycle.dig(:data, :image))
+          droplet.docker_receipt_image = message.lifecycle.dig(:data, :image)
+          droplet.process_types = message.lifecycle.dig(:data, :processTypes)
           droplet.mark_as_staged
-          droplet.process_types = { web: '' }
           droplet.save_changes
           build.mark_as_staged
           build.save_changes

spec/unit/actions/build_update_spec.rb

@@ -141,16 +141,21 @@ module VCAP::CloudController
                 type: 'kpack',
                 data: {
                   image: 'some-fake-image:tag',
+                  processTypes: {
+                    foo: 'foo start',
+                    bar: 'bar start',
+                  },
                 }
               }
             }
           end
 
-          it 'updates the state to STAGED' do
+          it 'updates the build state as STAGED and updates the droplet with correct metadata' do
             build_update.update(build, message)
 
             expect(build.state).to eq('STAGED')
             expect(build.droplet.docker_receipt_image).to eq('some-fake-image:tag')
+            expect(build.droplet.process_types).to eq({ 'foo' => 'foo start', 'bar' => 'bar start' })
           end
         end