v3(services): route binding last operation errors (cloudfoundry#1815)

[#174398276](https://www.pivotaltracker.com/story/show/174398276)

Author: blgm

app/actions/service_route_binding_create.rb

@@ -75,6 +75,16 @@ def poll(binding)
         else
           PollingNotComplete.new(details[:retry_after])
         end
+      rescue VCAP::Services::ServiceBrokers::V2::Errors::ServiceBrokerBadResponse,
+             VCAP::Services::ServiceBrokers::V2::Errors::ServiceBrokerResponseMalformed => e
+
+        binding.save_with_new_operation({}, {
+          type: 'create',
+          state: 'failed',
+          description: e.message,
+        })
+
+        raise e
       rescue => e
         binding.save_with_new_operation({}, {
           type: 'create',

app/jobs/v3/create_route_binding_job.rb

@@ -57,6 +57,10 @@ def perform
             self.polling_interval_seconds = polling_status.retry_after
           end
         end
+      rescue ServiceRouteBindingCreate::BindingNotRetrievable
+        raise CloudController::Errors::ApiError.new_from_details('ServiceBindingInvalid', 'The broker responded asynchronously but does not support fetching binding data')
+      rescue => e
+        raise CloudController::Errors::ApiError.new_from_details('UnableToPerform', 'bind', e.message)
       end
 
       private

spec/request/service_route_bindings_spec.rb

@@ -350,7 +350,7 @@
             expect(Delayed::Job.count).to eq(1)
           end
 
-          context 'last operation indicates success' do
+          context 'last operation response is 200 OK and indicates success' do
             let(:state) { 'succeeded' }
             let(:fetch_binding_status_code) { 200 }
             let(:fetch_binding_body) do
@@ -381,13 +381,24 @@
             end
           end
 
-          context 'last operation indicates failure' do
+          context 'last operation response is 200 OK and indicates failure' do
             let(:state) { 'failed' }
 
-            it 'does not queue another polling job' do
+            it 'updates the binding and job' do
               execute_all_jobs(expected_successes: 1, expected_failures: 0)
-              expect(Delayed::Job.count).to eq(0)
+
+              expect(binding.last_operation.type).to eq('create')
+              expect(binding.last_operation.state).to eq(state)
+              expect(binding.last_operation.description).to eq(description)
+
+              expect(job.state).to eq(VCAP::CloudController::PollableJobModel::COMPLETE_STATE)
             end
+          end
+
+          context 'last operation response is 400 Bad Request' do
+            let(:last_operation_status_code) { 400 }
+            let(:state) { 'failed' }
+            let(:description) { 'a helpful description' }
 
             it 'updates the binding and job' do
               execute_all_jobs(expected_successes: 1, expected_failures: 0)
@@ -399,6 +410,57 @@
               expect(job.state).to eq(VCAP::CloudController::PollableJobModel::COMPLETE_STATE)
             end
           end
+
+          context 'last operation response is 404 Not Found' do
+            let(:last_operation_status_code) { 404 }
+            let(:last_operation_body) { 'cannot see it' }
+
+            it 'updates the binding and job' do
+              execute_all_jobs(expected_successes: 1, expected_failures: 0)
+
+              expect(binding.last_operation.type).to eq('create')
+              expect(binding.last_operation.state).to eq('failed')
+              expect(binding.last_operation.description).to eq('The service broker rejected the request. Status Code: 404 Not Found, Body: "cannot see it"')
+
+              expect(job.state).to eq(VCAP::CloudController::PollableJobModel::COMPLETE_STATE)
+            end
+          end
+
+          context 'last operation response is 500 Internal Server Error' do
+            let(:last_operation_status_code) { 500 }
+            let(:last_operation_body) { 'something awful' }
+
+            it 'updates the binding and job' do
+              execute_all_jobs(expected_successes: 0, expected_failures: 1)
+
+              expect(binding.last_operation.type).to eq('create')
+              expect(binding.last_operation.state).to eq('failed')
+              expect(binding.last_operation.description).to eq('The service broker returned an invalid response. Status Code: 500 Internal Server Error, Body: "something awful"')
+
+              expect(job.state).to eq(VCAP::CloudController::PollableJobModel::FAILED_STATE)
+            end
+          end
+
+          context 'binding not retrievable' do
+            let(:offering) { VCAP::CloudController::Service.make(bindings_retrievable: false, requires: ['route_forwarding']) }
+
+            it 'fails the job with an appropriate error' do
+              execute_all_jobs(expected_successes: 0, expected_failures: 1)
+
+              expect(binding.last_operation.type).to eq('create')
+              expect(binding.last_operation.state).to eq('failed')
+              expect(binding.last_operation.description).to eq('The broker responded asynchronously but does not support fetching binding data')
+
+              expect(job.state).to eq(VCAP::CloudController::PollableJobModel::FAILED_STATE)
+              expect(job.cf_api_error).not_to be_nil
+              error = YAML.safe_load(job.cf_api_error)
+              expect(error['errors'].first).to include({
+                'code' => 90001,
+                'title' => 'CF-ServiceBindingInvalid',
+                'detail' => 'The service binding is invalid: The broker responded asynchronously but does not support fetching binding data',
+              })
+            end
+          end
         end
       end
 

spec/unit/jobs/v3/create_route_binding_job_spec.rb

@@ -47,17 +47,6 @@ module V3
           allow(V3::ServiceRouteBindingCreate).to receive(:new).and_return(action)
         end
 
-        context 'binding not found' do
-          it 'raises' do
-            binding.destroy
-
-            expect { subject.perform }.to raise_error(
-              CloudController::Errors::ApiError,
-              /The binding could not be found/,
-            )
-          end
-        end
-
         context 'first time' do
           context 'synchronous response' do
             let(:state) { 'succeeded' }
@@ -89,6 +78,21 @@ module V3
 
               expect(subject.finished).to be_falsey
             end
+
+            context 'bind fails with BindingNotRetrievable' do
+              before do
+                allow(action).to receive(:bind).and_raise(ServiceRouteBindingCreate::BindingNotRetrievable)
+              end
+
+              it 'raises an API error' do
+                expect {
+                  subject.perform
+                }.to raise_error(
+                  CloudController::Errors::ApiError,
+                  'The service binding is invalid: The broker responded asynchronously but does not support fetching binding data'
+                )
+              end
+            end
           end
         end
 
@@ -140,6 +144,39 @@ def test_retry_after(value, expected)
             test_retry_after(25.hours, 24.hours) # above limit
           end
         end
+
+        context 'binding not found' do
+          it 'raises an API error' do
+            binding.destroy
+
+            expect { subject.perform }.to raise_error(
+              CloudController::Errors::ApiError,
+              /The binding could not be found/,
+            )
+          end
+        end
+
+        context 'bind fails' do
+          it 'raises an API error' do
+            allow(action).to receive(:bind).and_raise(StandardError)
+
+            expect { subject.perform }.to raise_error(
+              CloudController::Errors::ApiError,
+              'bind could not be completed: StandardError',
+            )
+          end
+        end
+
+        context 'poll fails' do
+          it 'raises an API error' do
+            allow(action).to receive(:poll).and_raise(StandardError)
+
+            expect { subject.perform }.to raise_error(
+              CloudController::Errors::ApiError,
+              'bind could not be completed: StandardError',
+            )
+          end
+        end
       end
 
       describe '#operation' do