/v3/buildpacks returns Cloud Native Buildpacks

- Add KpackBuildpackListFetcher to translate K8s CRs into buildpack
  objects
- Add request spec
- Add new Kubeclient for interacting with experimental.kpack.pivotal.io api
- NOTE: Filtering does not work for CNBs

[#169924422]

Co-authored-by: Matt Royal <mroyal@pivotal.io>
Co-authored-by: Sannidhi Jalukar <sjalukar@pivotal.io>

Author: 2 people

app/controllers/v3/buildpacks_controller.rb

@@ -2,6 +2,7 @@
 require 'messages/buildpacks_list_message'
 require 'messages/buildpack_update_message'
 require 'messages/buildpack_upload_message'
+require 'fetchers/kpack_buildpack_list_fetcher'
 require 'fetchers/buildpack_list_fetcher'
 require 'actions/buildpack_create'
 require 'actions/buildpack_delete'
@@ -14,14 +15,23 @@ def index
     message = BuildpacksListMessage.from_params(query_params)
     invalid_param!(message.errors.full_messages) unless message.valid?
 
-    dataset = BuildpackListFetcher.new.fetch_all(message, eager_loaded_associations: Presenters::V3::BuildpackPresenter.associated_resources)
-
-    render status: :ok, json: Presenters::V3::PaginatedListPresenter.new(
-      presenter: Presenters::V3::BuildpackPresenter,
-      paginated_result: SequelPaginator.new.get_page(dataset, message.try(:pagination_options)),
-      path: '/v3/buildpacks',
-      message: message
-    )
+    if VCAP::CloudController::Config.kubernetes_api_configured?
+      dataset = KpackBuildpackListFetcher.new.fetch_all(message)
+      render status: :ok, json: Presenters::V3::PaginatedListPresenter.new(
+        presenter: Presenters::V3::BuildpackPresenter,
+        paginated_result: ListPaginator.new.get_page(dataset, message.try(:pagination_options)),
+        path: '/v3/buildpacks',
+        message: message
+      )
+    else
+      dataset = BuildpackListFetcher.new.fetch_all(message, eager_loaded_associations: Presenters::V3::BuildpackPresenter.associated_resources)
+      render status: :ok, json: Presenters::V3::PaginatedListPresenter.new(
+        presenter: Presenters::V3::BuildpackPresenter,
+        paginated_result: SequelPaginator.new.get_page(dataset, message.try(:pagination_options)),
+        path: '/v3/buildpacks',
+        message: message
+      )
+    end
   end
 
   def show

app/fetchers/kpack_buildpack_list_fetcher.rb

@@ -0,0 +1,87 @@
+require 'cloud_controller/paging/sequel_paginator'
+require 'cloud_controller/paging/paginated_result'
+require 'fetchers/null_filter_query_generator'
+
+module VCAP::CloudController
+  class KpackBuildpackListFetcher
+    def fetch_all(message)
+      staging_namespace = VCAP::CloudController::Config.config.get(:kubernetes, :kpack, :builder_namespace)
+      default_builder = kpack_client.get_custom_builder('cf-default-builder', staging_namespace)
+
+      version_map = default_builder.status.builderMetadata.each.with_object({}) do |metadata, h|
+        h[metadata.id] = metadata.version
+      end
+      stack = default_builder.spec.stack
+      created_at = Time.parse(default_builder.metadata.creationTimestamp)
+
+      latest_condition = default_builder.status.conditions[0]
+      if latest_condition
+        state = Buildpack::READY_STATE
+        updated_at = Time.parse(latest_condition.lastTransitionTime)
+      else
+        state = Buildpack::CREATED_STATE
+        updated_at = created_at
+      end
+
+      default_builder.spec.order.map do |entry|
+        name = entry.group.first.id
+        version = version_map.fetch(name, 'unknown')
+        KpackBuildpack.new(
+          id: "#{name}@#{version}",
+          name: name,
+          filename: "#{name}@#{version}",
+          stack: stack,
+          state: state,
+          created_at: created_at,
+          updated_at: updated_at,
+        )
+      end
+    end
+
+    private
+
+    def kpack_client
+      @kpack_client ||= CloudController::DependencyLocator.instance.kpack_client
+    end
+
+    class KpackBuildpack
+      attr_reader :filename, :id, :name, :stack, :state, :created_at, :updated_at
+
+      def initialize(filename:, id:, name:, stack:, state:, created_at:, updated_at:)
+        @filename = filename
+        @id = id
+        @name = name
+        @stack = stack
+        @state = state
+        @created_at = created_at
+        @updated_at = updated_at
+      end
+
+      def guid
+        nil
+      end
+
+      def position
+        0
+      end
+
+      def enabled?
+        true
+      end
+      alias_method :enabled, :enabled?
+
+      def locked?
+        false
+      end
+      alias_method :locked, :locked?
+
+      def labels
+        []
+      end
+
+      def annotations
+        []
+      end
+    end
+  end
+end

config/cloud_controller.yml

@@ -300,7 +300,7 @@ kubernetes:
   ca_file: "spec/fixtures/certs/kubernetes_ca.crt"
   workloads_namespace: 'cf-workloads'
   kpack:
-    builder_namespace: 'cf-workloads'
+    builder_namespace: 'cf-workloads-staging'
     registry_service_account_name: 'fake-registry-service-account'
     registry_tag_base: 'gcr.io/fake-image-repository'
 

lib/cloud_controller/dependency_locator.rb

@@ -370,14 +370,23 @@ def statsd_client
 
     def kpack_client
       kubernetes_config = VCAP::CloudController::Config.config.get(:kubernetes)
-      kube_client = Kubernetes::KubeClientBuilder.build({
+      service_account_token = File.open(kubernetes_config[:service_account][:token_file]).read
+      ca_crt = File.open(kubernetes_config[:ca_file]).read
+      build_kube_client = Kubernetes::KubeClientBuilder.build({
         api_group_url: "#{kubernetes_config[:host_url]}/apis/build.pivotal.io",
         version: 'v1alpha1',
-        service_account_token: File.open(kubernetes_config[:service_account][:token_file]).read,
-        ca_crt: File.open(kubernetes_config[:ca_file]).read
+        service_account_token: service_account_token,
+        ca_crt: ca_crt,
+      })
+
+      kpack_kube_client = Kubernetes::KubeClientBuilder.build({
+        api_group_url: "#{kubernetes_config[:host_url]}/apis/experimental.kpack.pivotal.io",
+        version: 'v1alpha1',
+        service_account_token: service_account_token,
+        ca_crt: ca_crt,
       })
 
-      Kubernetes::KpackClient.new(kube_client)
+      Kubernetes::KpackClient.new(build_kube_client: build_kube_client, kpack_kube_client: kpack_kube_client)
     end
 
     def route_crd_client

lib/kubernetes/kpack_client.rb

@@ -2,36 +2,45 @@
 
 module Kubernetes
   class KpackClient
-    def initialize(kube_client)
-      @client = kube_client
+    def initialize(build_kube_client:, kpack_kube_client:)
+      @build_kube_client = build_kube_client
+      @kpack_kube_client = kpack_kube_client
     end
 
     def create_image(*args)
-      @client.create_image(*args)
+      @build_kube_client.create_image(*args)
     rescue Kubeclient::HttpError => e
       raise CloudController::Errors::ApiError.new_from_details('KpackImageError', 'create', e.message)
     end
 
     def get_image(name, namespace)
-      @client.get_image(name, namespace)
+      @build_kube_client.get_image(name, namespace)
     rescue Kubeclient::ResourceNotFoundError
       nil
     rescue Kubeclient::HttpError => e
       raise CloudController::Errors::ApiError.new_from_details('KpackImageError', 'get', e.message)
     end
 
     def update_image(*args)
-      @client.update_image(*args)
+      @build_kube_client.update_image(*args)
     rescue Kubeclient::HttpError => e
       raise CloudController::Errors::ApiError.new_from_details('KpackImageError', 'update', e.message)
     end
 
     def delete_image(name, namespace)
-      @client.delete_image(name, namespace)
+      @build_kube_client.delete_image(name, namespace)
     rescue Kubeclient::ResourceNotFoundError
       nil
     rescue Kubeclient::HttpError => e
       raise CloudController::Errors::ApiError.new_from_details('KpackImageError', 'delete', e.message)
     end
+
+    def get_custom_builder(name, namespace)
+      @kpack_kube_client.get_custom_builder(name, namespace)
+    rescue Kubeclient::ResourceNotFoundError
+      nil
+    rescue Kubeclient::HttpError => e
+      raise CloudController::Errors::ApiError.new_from_details('KpackCustomBuilderError', 'get', e.message)
+    end
   end
 end