v3(services): test order_by for services resources (cloudfoundry#1797)

* v3(services): refactor some inconsistent whitespace

[#169146261](https://www.pivotaltracker.com/story/show/169146261)

* v3(services): test order_by for services resources

- implemented order_by name where it was not implemented already except
  for service offerings where it is complex due to the DB column being
  called label rather than name
- improved the pagination shared example to check links

[#169146261](https://www.pivotaltracker.com/story/show/169146261)

* v3(services): action comments from review

[#169146261](https://www.pivotaltracker.com/story/show/169146261)

Author: blgm

app/controllers/v3/service_credential_bindings_controller.rb

@@ -15,7 +15,7 @@ def index
 
     presenter = Presenters::V3::PaginatedListPresenter.new(
       presenter: Presenters::V3::ServiceCredentialBindingPresenter,
-      paginated_result: SequelPaginator.new.get_page(results, pagination_options),
+      paginated_result: SequelPaginator.new.get_page(results, message.try(:pagination_options)),
       path: '/v3' + service_credential_bindings_path,
       message: message,
       decorators: decorators(message)

app/messages/apps_list_message.rb

@@ -23,7 +23,7 @@ class AppsListMessage < MetadataListMessage
     validates :stacks, array: true, allow_nil: true
 
     def valid_order_by_values
-      super << :name
+      super + [:name]
     end
 
     def self.from_params(params)

app/messages/isolation_segments_list_message.rb

@@ -19,7 +19,7 @@ def self.from_params(params)
     end
 
     def valid_order_by_values
-      super << :name
+      super + [:name]
     end
   end
 end

app/messages/orgs_list_message.rb

@@ -22,7 +22,7 @@ def self.from_params(params)
     end
 
     def valid_order_by_values
-      super << :name
+      super + [:name]
     end
   end
 end

app/messages/service_brokers_list_message.rb

@@ -14,7 +14,7 @@ class ServiceBrokersListMessage < MetadataListMessage
     validates :names, array: true, allow_nil: true
 
     def valid_order_by_values
-      super << :name
+      super + [:name]
     end
 
     def self.from_params(params)

app/messages/service_credential_bindings_list_message.rb

@@ -24,5 +24,9 @@ class ServiceCredentialBindingsListMessage < ListMessage
     def self.from_params(params)
       super(params, ARRAY_KEYS.map(&:to_s))
     end
+
+    def valid_order_by_values
+      super + [:name]
+    end
   end
 end

app/messages/service_instances_list_message.rb

@@ -43,7 +43,7 @@ def to_param_hash
     end
 
     def valid_order_by_values
-      super << :name
+      super + [:name]
     end
   end
 end

app/messages/service_plans_list_message.rb

@@ -32,6 +32,10 @@ class ServicePlansListMessage < MetadataListMessage
       }
     }
 
+    def valid_order_by_values
+      super + [:name]
+    end
+
     def self.from_params(params)
       super(params, @array_keys.map(&:to_s), fields: %w(fields))
     end

app/messages/spaces_list_message.rb

@@ -21,7 +21,7 @@ def self.from_params(params)
     end
 
     def valid_order_by_values
-      super << :name
+      super + [:name]
     end
   end
 end

app/messages/stacks_list_message.rb

@@ -15,7 +15,7 @@ def self.from_params(params)
     end
 
     def valid_order_by_values
-      super << :name
+      super + [:name]
     end
   end
 end