Skip to content
This repository was archived by the owner on Jun 2, 2021. It is now read-only.

Commit a376564

Browse files
Make Image CR stager upgrade to CustomBuilder
- This change supports upgrades from cf-for-k8s versions with the Builder to versions with the new CustomBuilder (cf-default-builder). [finishes #173536510] Co-authored-by: Piyali Banerjee <pbanerjee@pivotal.io> Co-authored-by: Connor Braa <cbraa@pivotal.io>
1 parent 31a6e5c commit a376564

2 files changed

Lines changed: 10 additions & 6 deletions

File tree

lib/cloud_controller/kpack/stager.rb

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
module Kpack
22
class Stager
3+
CF_DEFAULT_BUILDER = {
4+
name: 'cf-default-builder',
5+
kind: 'CustomBuilder'
6+
}.freeze
37
APP_GUID_LABEL_KEY = 'cloudfoundry.org/app_guid'.freeze
48
BUILD_GUID_LABEL_KEY = 'cloudfoundry.org/build_guid'.freeze
59
STAGING_SOURCE_LABEL_KEY = 'cloudfoundry.org/source_type'.freeze
@@ -47,6 +51,7 @@ def update_image_resource(image, staging_details)
4751
image.metadata.labels[BUILD_GUID_LABEL_KEY.to_sym] = staging_details.staging_guid
4852
image.spec.source.blob.url = blobstore_url_generator.package_download_url(staging_details.package)
4953
image.spec.build.env = get_environment_variables(staging_details)
54+
image.spec.builder = CF_DEFAULT_BUILDER
5055

5156
image
5257
end
@@ -67,10 +72,7 @@ def image_resource(staging_details)
6772
},
6873
spec: {
6974
serviceAccount: registry_service_account_name,
70-
builder: {
71-
name: 'cf-default-builder',
72-
kind: 'CustomBuilder'
73-
},
75+
builder: CF_DEFAULT_BUILDER,
7476
tag: "#{registry_tag_base}/#{staging_details.package.app.guid}",
7577
source: {
7678
blob: {

spec/unit/lib/cloud_controller/kpack/stager_spec.rb

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -131,8 +131,8 @@ module Kpack
131131
tag: "gcr.io/capi-images/#{package.app.guid}",
132132
serviceAccount: 'gcr-service-account',
133133
builder: {
134-
name: 'cf-default-builder',
135-
kind: 'CustomBuilder'
134+
name: 'cf-autodetect-builder', # legacy Builder to verify that image update includes new CustomBuilder
135+
kind: 'Builder'
136136
},
137137
source: {
138138
blob: {
@@ -161,6 +161,8 @@ module Kpack
161161
updated_image.spec.build.env = [
162162
{ name: 'FOO', value: 'BAR' }
163163
]
164+
updated_image.spec.builder.kind = 'CustomBuilder'
165+
updated_image.spec.builder.name = 'cf-default-builder'
164166

165167
expect(client).to_not receive(:create_image)
166168
expect(client).to receive(:update_image).with(updated_image)

0 commit comments

Comments
 (0)