v3(route-bindings): fail the create job when a delete starts (cloudfoundry#1943)

[#174748134](https://www.pivotaltracker.com/story/show/174748134)

Author: Derik Evangelista

app/jobs/v3/create_binding_async_job.rb

@@ -7,6 +7,8 @@
 module VCAP::CloudController
   module V3
     class CreateBindingAsyncJob < Jobs::ReoccurringJob
+      class OperationCancelled < StandardError; end
+
       class BindingNotFound < CloudController::Errors::ApiError; end
 
       def initialize(type, precursor_guid, parameters:, user_audit_info:, audit_hash:)
@@ -54,6 +56,8 @@ def resource_type
       def perform
         not_found! unless resource
 
+        cancelled! if delete_in_progress?
+
         compute_maximum_duration
 
         if @first_time
@@ -72,6 +76,8 @@ def perform
         if polling_status[:retry_after].present?
           self.polling_interval_seconds = polling_status[:retry_after]
         end
+      rescue OperationCancelled => e
+        raise CloudController::Errors::ApiError.new_from_details('UnableToPerform', operation_type, e.message)
       rescue BindingNotFound => e
         raise e
       rescue ServiceBindingCreate::BindingNotRetrievable
@@ -107,6 +113,14 @@ def not_found!
         raise BindingNotFound.new_from_details('ResourceNotFound', "The binding could not be found: #{@resource_guid}")
       end
 
+      def delete_in_progress?
+        resource.operation_in_progress? && resource.last_operation&.type == 'delete'
+      end
+
+      def cancelled!
+        raise OperationCancelled.new("#{resource.last_operation.type} in progress")
+      end
+
       def save_failure(error_message)
         if resource.reload.last_operation.state != 'failed'
           resource.save_with_attributes_and_new_operation(

spec/support/shared_examples/jobs/create_binding_job.rb

@@ -158,6 +158,23 @@
           end
         end
       end
+
+      context 'when the operation changes' do
+        before do
+          binding.save_with_attributes_and_new_operation({}, { type: 'delete', state: 'in progress' })
+        end
+
+        it 'raises an error' do
+          expect { subject.perform }.to raise_error(
+            CloudController::Errors::ApiError,
+              /create could not be completed: delete in progress/
+          )
+
+          binding.reload
+          expect(binding.last_operation.state).to eq('in progress')
+          expect(binding.last_operation.type).to eq('delete')
+        end
+      end
     end
 
     context 'retry interval' do