Update rubocop to 0.90.0

- Disable Lint/UselessMethodDefinition because adhering to it breaks things. I
believe this is mostly because we are overriding constructors to
suppress superclass behavior. This is probably not great design, but
fixing it is outside the scope of this commit.
- Disable Style/CombinableLoops because it requires some significant
restructuring. Also there is some async processing in
diego/reporters/instances_reporter.rb that might break if the loops are
combined.
- Disable Style/KeywordParametersOrder to avoid changing existing method
interfaces.
- Disable Style/SoleNestedConditional because it involves some
significant restructuring. This might be a good thing to enable in the
future.

Authored-by: Greg Cobb <gcobb@pivotal.io>

Author: Gerg

.rubocop.yml

@@ -411,3 +411,27 @@ Style/StringConcatenation:
 
 Bundler/OrderedGems:
   Enabled: false
+
+Lint/DuplicateRequire:
+  Enabled: true
+
+Lint/EmptyFile:
+  Enabled: true
+
+Lint/TrailingCommaInAttributeDeclaration:
+  Enabled: true
+
+Lint/UselessMethodDefinition:
+  Enabled: false
+
+Style/CombinableLoops:
+  Enabled: false
+
+Style/KeywordParametersOrder:
+  Enabled: false
+
+Style/RedundantSelfAssignment:
+  Enabled: true
+
+Style/SoleNestedConditional:
+  Enabled: false

Gemfile

@@ -88,7 +88,7 @@ group :test do
   gem 'rspec-rails', '~> 3.9.1'
   gem 'rspec-wait'
   gem 'rspec_api_documentation', '>= 6.1.0'
-  gem 'rubocop', '~> 0.89.0'
+  gem 'rubocop', '~> 0.90.0'
   gem 'timecop'
   gem 'webmock', '> 2.3.1'
 end

Gemfile.lock

@@ -395,7 +395,7 @@ GEM
       activesupport (>= 3.0.0)
       mustache (~> 1.0, >= 0.99.4)
       rspec (~> 3.0)
-    rubocop (0.89.1)
+    rubocop (0.90.0)
       parallel (~> 1.10)
       parser (>= 2.7.1.1)
       rainbow (>= 2.2.2, < 4.0)
@@ -567,7 +567,7 @@ DEPENDENCIES
   rspec-rails (~> 3.9.1)
   rspec-wait
   rspec_api_documentation (>= 6.1.0)
-  rubocop (~> 0.89.0)
+  rubocop (~> 0.90.0)
   ruby-debug-ide (>= 0.7.0.beta4)
   rubyzip (>= 1.3.0)
   scientist (~> 1.1.0)

app/actions/app_delete.rb

@@ -11,7 +11,6 @@
 require 'actions/process_delete'
 require 'actions/sidecar_delete'
 require 'actions/route_mapping_delete'
-require 'actions/sidecar_delete'
 require 'actions/staging_cancel'
 
 module VCAP::CloudController

app/models.rb

@@ -110,6 +110,7 @@
 require 'models/services/service_offering_annotation_model'
 require 'models/services/service_binding'
 require 'models/services/route_binding'
+require 'models/services/route_binding_operation'
 require 'models/services/service_dashboard_client'
 require 'models/services/service_instance'
 require 'models/services/managed_service_instance'
@@ -129,8 +130,6 @@
 require 'models/services/service_plan_label_model'
 require 'models/services/service_usage_event'
 require 'models/services/service_key'
-require 'models/services/route_binding'
-require 'models/services/route_binding_operation'
 require 'models/services/service_credential_binding_view'
 
 require 'models/request_count'

spec/performance/processes_spec.rb

@@ -1,5 +1,4 @@
 require 'spec_helper'
-require 'spec_helper'
 
 module VCAP::CloudController
   RSpec.describe AnnotationsUpdate do