Skip to content
This repository was archived by the owner on Jun 2, 2021. It is now read-only.

Commit b35e2d8

Browse files
reidmitBrian Cunnie
andcommitted
🐞 V3: GET /v3/apps/:guid/permissions
Space developers can read sensitive data. [finishes #169770887] Co-authored-by: Reid Mitchell <rmitchell@pivotal.io> Co-authored-by: Brian Cunnie <bcunnie@pivotal.io>
1 parent 1095365 commit b35e2d8

3 files changed

Lines changed: 4 additions & 4 deletions

File tree

β€Žapp/controllers/v3/apps_controller.rbβ€Ž

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -329,7 +329,7 @@ def show_permissions
329329

330330
render status: :ok, json: {
331331
read_basic_data: true,
332-
read_sensitive_data: permission_queryer.can_read_secrets_globally?,
332+
read_sensitive_data: permission_queryer.can_read_secrets_in_space?(space.guid, org.guid),
333333
}
334334
end
335335

β€Ždocs/v3/source/includes/resources/apps/_permissions.md.erbβ€Ž

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,8 @@ Content-Type: application/json
2525
```
2626

2727
Get the current user's permissions for the given app. If a user can see an app,
28-
then they can see its basic data. Only admin and read-only admins can read sensitive
29-
data.
28+
then they can see its basic data. Only admin, read-only admins, and space
29+
developers can read sensitive data.
3030

3131
#### Definition
3232
`GET /v3/apps/:guid/permissions`

β€Žspec/request/apps_spec.rbβ€Ž

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2554,7 +2554,7 @@
25542554
h['org_manager'] = { code: 200, response_object: read_basic_response }
25552555
h['space_manager'] = { code: 200, response_object: read_basic_response }
25562556
h['space_auditor'] = { code: 200, response_object: read_basic_response }
2557-
h['space_developer'] = { code: 200, response_object: read_basic_response }
2557+
h['space_developer'] = { code: 200, response_object: read_all_response }
25582558
h.freeze
25592559
end
25602560

0 commit comments

Comments
Β (0)