Filter out VCAP_SERVICES from environment variables

Author: kramerul

lib/cloud_controller/kpack/stager.rb

@@ -76,9 +76,10 @@ def image_resource(staging_details)
               url: blobstore_url_generator.package_download_url(staging_details.package),
             }
           },
-          build: { 
+          build: {
             env: staging_details.environment_variables.to_a.
-                  map{ | key , value |  {name: key, value: value.to_s() }  }
+                  delete_if { |key, value| key == 'VCAP_SERVICES' }.
+                  map { |key, value| { name: key, value: value.to_s } }
           }
         }
       })

spec/unit/lib/cloud_controller/kpack/stager_spec.rb

@@ -11,7 +11,7 @@ module Kpack
     )
     }
     let(:package) { VCAP::CloudController::PackageModel.make }
-    let(:environment_variables) { { 'BP_JAVA_VERSION' => '8.*', 'BPL_HEAD_ROOM' => 0}  }
+    let(:environment_variables) { { 'BP_JAVA_VERSION' => '8.*', 'BPL_HEAD_ROOM' => 0, 'VCAP_SERVICES' => { postgres: [] } } }
     let(:staging_memory_in_mb) { 1024 }
     let(:staging_disk_in_mb) { 1024 }
     let(:blobstore_url_generator) do
@@ -79,7 +79,7 @@ module Kpack
               }
             },
             build: {
-              env: [ {name: "BP_JAVA_VERSION", value: "8.*"} , {name: "BPL_HEAD_ROOM", value: "0"}]
+              env: [{ name: 'BP_JAVA_VERSION', value: '8.*' }, { name: 'BPL_HEAD_ROOM', value: '0' }]
             }
           }
         }))