log k8s client errors when translating to ApiErrors in ApiClient

- for cloudfoundry/capi-k8s-release#48 this should make logging around route update 422s clearer

[#173583970]

Co-authored-by: Connor Braa <cbraa@pivotal.io>
Co-authored-by: Piyali Banerjee <pbanerjee@pivotal.io>

Author: cwlbraa

lib/kubernetes/api_client.rb

@@ -11,6 +11,7 @@ def initialize(build_kube_client:, kpack_kube_client:, route_kube_client:)
     def create_image(resource_config)
       @build_kube_client.create_image(resource_config)
     rescue Kubeclient::HttpError => e
+      logger.error('create_image', error: e.inspect, response: e.response, backtrace: e.backtrace)
       raise CloudController::Errors::ApiError.new_from_details('KpackImageError', 'create', e.message)
     end
 
@@ -19,12 +20,14 @@ def get_image(name, namespace)
     rescue Kubeclient::ResourceNotFoundError
       nil
     rescue Kubeclient::HttpError => e
+      logger.error('get_image', error: e.inspect, response: e.response, backtrace: e.backtrace)
       raise CloudController::Errors::ApiError.new_from_details('KpackImageError', 'get', e.message)
     end
 
     def update_image(resource_config)
       @build_kube_client.update_image(resource_config)
     rescue Kubeclient::HttpError => e
+      logger.error('update_image', error: e.inspect, response: e.response, backtrace: e.backtrace)
       raise CloudController::Errors::ApiError.new_from_details('KpackImageError', 'update', e.message)
     end
 
@@ -33,12 +36,14 @@ def delete_image(name, namespace)
     rescue Kubeclient::ResourceNotFoundError
       nil
     rescue Kubeclient::HttpError => e
+      logger.error('delete_image', error: e.inspect, response: e.response, backtrace: e.backtrace)
       raise CloudController::Errors::ApiError.new_from_details('KpackImageError', 'delete', e.message)
     end
 
     def create_route(resource_config)
       @route_kube_client.create_route(resource_config)
     rescue Kubeclient::HttpError => e
+      logger.error('create_route', error: e.inspect, response: e.response, backtrace: e.backtrace)
       error = CloudController::Errors::ApiError.new_from_details('KubernetesRouteResourceError', resource_name(resource_config))
       error.set_backtrace(e.backtrace)
       raise error
@@ -49,6 +54,7 @@ def get_route(name, namespace)
     rescue Kubeclient::ResourceNotFoundError
       nil
     rescue Kubeclient::HttpError => e
+      logger.error('get_route', error: e.inspect, response: e.response, backtrace: e.backtrace)
       error = CloudController::Errors::ApiError.new_from_details('KubernetesRouteResourceError', name)
       error.set_backtrace(e.backtrace)
       raise error
@@ -57,7 +63,8 @@ def get_route(name, namespace)
     def update_route(resource_config)
       @route_kube_client.update_route(resource_config)
     rescue Kubeclient::HttpError => e
-      error = CloudController::Errors::ApiError.new_from_details('KubernetesRouteResourceError', resource_name(resource_config))
+      logger.error('update_route', error: e.inspect, response: e.response, backtrace: e.backtrace)
+      error = CloudController::Errors::ApiError.new_from_details('KubernetesRouteResourceError', resource_name(resource_config), e.message, e.response)
       error.set_backtrace(e.backtrace)
       raise error
     end
@@ -67,6 +74,7 @@ def delete_route(name, namespace)
     rescue Kubeclient::ResourceNotFoundError
       nil
     rescue Kubeclient::HttpError => e
+      logger.error('delete_route', error: e.inspect, response: e.response, backtrace: e.backtrace)
       error = CloudController::Errors::ApiError.new_from_details('KubernetesRouteResourceError', name)
       error.set_backtrace(e.backtrace)
       raise error
@@ -77,11 +85,18 @@ def get_custom_builder(name, namespace)
     rescue Kubeclient::ResourceNotFoundError
       nil
     rescue Kubeclient::HttpError => e
-      raise CloudController::Errors::ApiError.new_from_details('KpackCustomBuilderError', 'get', e.message)
+      logger.error('get_custom_builder', error: e.inspect, response: e.response, backtrace: e.backtrace)
+      error = CloudController::Errors::ApiError.new_from_details('KpackCustomBuilderError', 'get', e.message)
+      error.set_backtrace(e.backtrace)
+      raise error
     end
 
     private
 
+    def logger
+      Steno.logger('kubernetes.api_client')
+    end
+
     def resource_name(resource_config)
       resource_metadata = resource_config.to_hash.symbolize_keys[:metadata] || {}
       resource_metadata.fetch(:name, '')

spec/unit/lib/kubernetes/api_client_spec.rb

@@ -199,12 +199,18 @@
       end
 
       context 'when there is an error' do
-        it 'raises as an ApiError' do
-          allow(route_kube_client).to receive(:get_route).and_raise(Kubeclient::HttpError.new(422, 'foo', 'bar'))
+        let(:error) { Kubeclient::HttpError.new(422, 'foo', 'bar') }
+        let(:logger) { instance_double(Steno::Logger, error: nil) }
+        before do
+          allow(route_kube_client).to receive(:get_route).and_raise(error)
+          allow(Steno).to receive(:logger).and_return(logger)
+        end
 
+        it 'raises as an ApiError' do
           expect {
             subject.get_route('resource-name', 'namespace')
           }.to raise_error(CloudController::Errors::ApiError, /resource-name/)
+          expect(logger).to have_received(:error).with('get_route', error: /status code/, response: error.response, backtrace: error.backtrace)
         end
       end
     end
@@ -224,8 +230,11 @@
       end
 
       context 'when there is an error' do
+        let(:error) { Kubeclient::HttpError.new(422, 'foo', 'bar') }
+        let(:logger) { instance_double(Steno::Logger, error: nil) }
         before do
-          allow(route_kube_client).to receive(:update_route).and_raise(Kubeclient::HttpError.new(422, 'foo', 'bar'))
+          allow(route_kube_client).to receive(:update_route).and_raise(error)
+          allow(Steno).to receive(:logger).and_return(logger)
         end
 
         context 'when the config is a Kubeclient::Resource' do
@@ -235,6 +244,7 @@
             expect {
               subject.update_route(resource_config)
             }.to raise_error(CloudController::Errors::ApiError, /resource-name/)
+            expect(logger).to have_received(:error).with('update_route', error: /status code/, response: error.response, backtrace: error.backtrace)
           end
         end