Skip to content
This repository was archived by the owner on Jun 2, 2021. It is now read-only.

Commit bfdbd72

Browse files
author
Brian Butz
committed
v3(services): properly audit all of message when creating service instance
[#172644751](https://www.pivotaltracker.com/story/show/172644751)
1 parent dba205f commit bfdbd72

2 files changed

Lines changed: 10 additions & 3 deletions

File tree

app/actions/service_instance_create_managed.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@ def create(message)
4444
creation_job = V3::CreateServiceInstanceJob.new(
4545
instance.guid,
4646
arbitrary_parameters: message.parameters,
47+
request_attr: message.audit_hash,
4748
user_audit_info: service_event_repository.user_audit_info
4849
)
4950
pollable_job = Jobs::Enqueuer.new(creation_job, queue: Jobs::Queues.generic).enqueue_pollable

app/jobs/v3/create_service_instance_job.rb

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,15 @@
33
module VCAP::CloudController
44
module V3
55
class CreateServiceInstanceJob < ServiceInstanceAsyncJob
6-
def initialize(service_instance_guid, arbitrary_parameters: {}, user_audit_info:)
6+
def initialize(
7+
service_instance_guid,
8+
arbitrary_parameters: {},
9+
request_attr: {},
10+
user_audit_info:
11+
)
712
super(service_instance_guid, user_audit_info)
8-
@request_attr = arbitrary_parameters
13+
@request_attr = request_attr
14+
@arbitrary_parameters = arbitrary_parameters
915
end
1016

1117
def operation
@@ -20,7 +26,7 @@ def send_broker_request(client)
2026
client.provision(
2127
service_instance,
2228
accepts_incomplete: true,
23-
arbitrary_parameters: @request_attr,
29+
arbitrary_parameters: @arbitrary_parameters,
2430
maintenance_info: service_instance.service_plan.maintenance_info
2531
)
2632
end

0 commit comments

Comments
 (0)