v3(services): refactor SI job tests (cloudfoundry#1735)

Author: Derik Evangelista

app/jobs/v3/delete_service_instance_job.rb

@@ -27,15 +27,9 @@ def operation_type
         'delete'
       end
 
-      private
-
       def gone!
         finish
       end
-
-      def compatibility_checks
-        nil
-      end
     end
   end
 end

app/jobs/v3/service_instance_async_job.rb

@@ -41,14 +41,12 @@ def perform
             operation_succeeded
             record_event(si, @request_attr)
             finish
-
-            return
           end
         rescue => err
           fail!(err)
         end
 
-        if service_instance.last_operation.state == 'failed'
+        if service_instance.present? && service_instance.last_operation.state == 'failed'
           operation_failed!(service_instance.last_operation.description)
         end
       end

app/jobs/v3/update_service_instance_job.rb

@@ -32,10 +32,6 @@ def send_broker_request(client)
         @update_response
       end
 
-      private
-
-      attr_reader :message
-
       def operation_succeeded
         updates = message.updates.tap do |u|
           u[:service_plan_guid] = service_plan.guid
@@ -46,10 +42,13 @@ def operation_succeeded
         ServiceInstance.db.transaction do
           service_instance.update_service_instance(updates)
           MetadataUpdate.update(service_instance, message)
-          record_event(service_instance, message.audit_hash)
         end
       end
 
+      private
+
+      attr_reader :message
+
       def service_plan_gone!
         raise CloudController::Errors::ApiError.new_from_details('ServicePlanNotFound', service_instance_guid)
       end